From: Douglas Gilbert Subject: Re: [PATCH 21/24] sg: switch to SPDX tags Date: Sun, 5 May 2019 22:04:58 +0200 Message-ID: <4285486a-b30c-300c-e794-e74999b15fb2@interlog.com> References: <20190501161417.32592-1-hch@lst.de> <20190501161417.32592-22-hch@lst.de> Reply-To: open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Return-path: Sender: open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20190501161417.32592-22-hch-jcswGhMUV9g@public.gmane.org> Content-Language: en-CA List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Christoph Hellwig , "James E . J . Bottomley" , "Martin K . Petersen" Cc: Hannes Reinecke , Lee Duncan , Chris Leech , Willem Riede , Jens Axboe , =?UTF-8?Q?Kai_M=c3=a4kisara?= , linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, osst-users-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-scsi@vger.kernel.org On 2019-05-01 6:14 p.m., Christoph Hellwig wrote: > Use the the GPLv2+ SPDX tag instead of verbose boilerplate text. > > Signed-off-by: Christoph Hellwig This scripts/checkpatch.pl noise seems to be related to the patch below: $ scripts/checkpatch.pl /tmp/t.patch Traceback (most recent call last): File "scripts/spdxcheck.py", line 6, in from ply import lex, yacc ImportError: No module named ply total: 0 errors, 0 warnings, 98 lines checked That happens both in the mkp/scsi/5.2/scsi-queue and the latest linux-stable trees. BTW Are C++ comments (as used in this patch) now permitted in lk code? Doug Gilbert > --- > drivers/scsi/sg.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c > index d3f15319b9b3..bcdc28e5ede7 100644 > --- a/drivers/scsi/sg.c > +++ b/drivers/scsi/sg.c > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: GPL-2.0+ > /* > * History: > * Started: Aug 9 by Lawrence Foard (entropy-Jk6FQSss4Zz2eFz/2MeuCQ@public.gmane.org), > @@ -8,12 +9,6 @@ > * Copyright (C) 1992 Lawrence Foard > * Version 2 and 3 extensions to driver: > * Copyright (C) 1998 - 2014 Douglas Gilbert > - * > - * This program is free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License as published by > - * the Free Software Foundation; either version 2, or (at your option) > - * any later version. > - * > */ > > static int sg_version_num = 30536; /* 2 digits for each component */ > -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org Visit this group at https://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout.