From: Jeff Garzik Subject: Re: [RFC] [PATCH] OCFS2 Date: Thu, 19 May 2005 06:26:50 -0400 Message-ID: <428C69EA.6080001@pobox.com> References: <20050518223303.GE1340@ca-server1.us.oracle.com> <200505190230.23624.phillips@istop.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: Mark Fasheh , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com, torvalds@osdl.org, akpm@osdl.org, wim.coekaerts@oracle.com, lmb@suse.de Return-path: Received: from mail.dvmed.net ([216.237.124.58]:50352 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S261537AbVESK07 (ORCPT ); Thu, 19 May 2005 06:26:59 -0400 To: Daniel Phillips In-Reply-To: <200505190230.23624.phillips@istop.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Daniel Phillips wrote: > Zero terminated strings for lock names is bad taste. It generates a bunch of > useless strlen executions and you force an ascii namespace for no apparent > reason. Add a 9th parameter, namelen, to the lock call maybe? What's wrong with ascii strings? We call those 'UTF8' these days. Jeff