From: Michael Krufky Date: Wed, 20 Jul 2005 19:45:12 +0000 Subject: [KJ] Re: [PATCH] drivers/media/video/bttv-driver: Remove unneeded Message-Id: <42DEA9C8.6020406@m1k.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org Tobias Klauser wrote: >In bttv-driver.c pci_dma_supported() is called after pci_set_dma_mask() >which already did check that for us. The attached patch removes the >unneeded call to pci_dma_supported() > >Signed-off-by: Tobias Klauser > >--- > > bttv-driver.c | 5 ----- > 1 files changed, 5 deletions(-) > >diff -urpN -X dontdiff linux-2.6.13-rc2/drivers/media/video/bttv-driver.c linux-2.6.13-rc2~dma_mask/drivers/media/video/bttv-driver.c >--- linux-2.6.13-rc2/drivers/media/video/bttv-driver.c 2005-07-07 21:28:50.000000000 +0200 >+++ linux-2.6.13-rc2~dma_mask/drivers/media/video/bttv-driver.c 2005-07-07 22:43:50.000000000 +0200 >@@ -3880,11 +3881,6 @@ static int __devinit bttv_probe(struct p > pci_set_master(dev); > pci_set_command(dev); > pci_set_drvdata(dev,btv); >- if (!pci_dma_supported(dev,0xffffffff)) { >- printk("bttv%d: Oops: no 32bit PCI DMA ???\n", btv->c.nr); >- result = -EIO; >- goto fail1; >- } > > pci_read_config_byte(dev, PCI_CLASS_REVISION, &btv->revision); > pci_read_config_byte(dev, PCI_LATENCY_TIMER, &lat); > >-- >video4linux-list mailing list >Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe >https://www.redhat.com/mailman/listinfo/video4linux-list > > Applied to video4linux cvs... /Wed Jul 20 19:43:24 2005 UTC/ (55 seconds ago) by /mkrufky/ * bttv-driver.c: - pci_dma_supported() is called after pci_set_dma_mask() which already did check that for us. The attached patch removes the unneeded call to pci_dma_supported() Signed-off-by: Tobias Klauser Signed-off-by: Michael Krufky -- Michael Krufky _______________________________________________ Kernel-janitors mailing list Kernel-janitors@lists.osdl.org https://lists.osdl.org/mailman/listinfo/kernel-janitors