Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8894C433ED for ; Mon, 17 May 2021 23:46:03 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6931761185 for ; Mon, 17 May 2021 23:46:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6931761185 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.128536.241298 (Exim 4.92) (envelope-from ) id 1limvr-0008WM-Sk; Mon, 17 May 2021 23:45:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 128536.241298; Mon, 17 May 2021 23:45:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1limvr-0008WF-Pc; Mon, 17 May 2021 23:45:55 +0000 Received: by outflank-mailman (input) for mailman id 128536; Mon, 17 May 2021 23:45:54 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1limvq-0008W9-2G for xen-devel@lists.xenproject.org; Mon, 17 May 2021 23:45:54 +0000 Received: from mail-oi1-x22e.google.com (unknown [2607:f8b0:4864:20::22e]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 341beecd-4ff2-4ed8-99c6-76f2ec0071a0; Mon, 17 May 2021 23:45:53 +0000 (UTC) Received: by mail-oi1-x22e.google.com with SMTP id b25so8142005oic.0 for ; Mon, 17 May 2021 16:45:53 -0700 (PDT) Received: from [192.168.99.80] (142-79-211-230.starry-inc.net. [142.79.211.230]) by smtp.gmail.com with ESMTPSA id l11sm3289900ooq.44.2021.05.17.16.45.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 May 2021 16:45:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 341beecd-4ff2-4ed8-99c6-76f2ec0071a0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=0Td9hzMwh0l7nVPyPWJs5h3Oib92yw47wCHz+OsqDpw=; b=T+6mAgbkl+b8IFSlSCGNMM2mJ/c/iaQFGhfg6fP+HM61EYma0ePPNTI/OB+njrnd2a +fvSUhqhKPwSDUPToS4Nu9YJUnjUiKhkNlVQP8+3glRYY2O6c+9w1ATKIlxdrBXO1G16 C4RRJmV8vh6FfMiCtQhu585ep47HhFEtBUM11aueYYPhvvjI94zFl464SdsaSlKJiCog D3ht30rZgSEMEwt7VCjCHLb7plwbB8jlALbul8r7QQTA+0xHbaMyhcx0wlexU1BguHza Y3fI60035uurmYTAM6jrUtunD0KccuF3vFux8W6qeqUFmX0BgLZvHFMybZvVz8bGEa9I BXQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=0Td9hzMwh0l7nVPyPWJs5h3Oib92yw47wCHz+OsqDpw=; b=lRxc0FwUcKt+u60E4hx854hV9+FyH/0KKllgPxH8EE1OT9nfNkA9hVTAvisoLAtqp1 7Vz4Jp3EW1tWUE2r/rbdR4txDgM4LKNq5QcS2AGbLGwQcoXCbcIkfWtobVtdVrBjIkHy w/TzDhcPaRhNCOdg3GRa1CvfdewN3OKgolpr/q5eDGkjKZt+t8yJmByvFZz/6gEsNejF ZeiuvDncRgFLIe/8eJH8CEEBCEB3f0jqyU62BRs8NBjMbGbbmyLNpsagWajyst4Tpji9 ITlIbH2mScHCsMCHduGEkBBKrFAyIkOp1Dysj7hWaKBH4u63Yriif9ppyU6BXEj3EJER 9Ang== X-Gm-Message-State: AOAM530j4QwzeqkoZkOBdQV5yXf6j4tsXyqInGNYqWfQ2FjLji/JBYA5 Qowi2bRz3g549j9QEQ9WhIhc+MaN/cdV+w== X-Google-Smtp-Source: ABdhPJzHyDxnUrn7L68qr7XKG/umoQqc5tYC5XKWM9l8HmSbyEg8bbSKHVYxHsr6srMr/fZvEm9EsA== X-Received: by 2002:aca:c6d7:: with SMTP id w206mr1735235oif.87.1621295152791; Mon, 17 May 2021 16:45:52 -0700 (PDT) Subject: Re: [PATCH v3 3/5] xen: Fix build when !CONFIG_GRANT_TABLE To: Jan Beulich Cc: Bobby Eshleman , Alistair Francis , Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <834f7995ae80a3b37b6d508d1c989b4ee391f61b.1621017334.git.connojdavis@gmail.com> From: Connor Davis Message-ID: <42d16824-0dd2-0aea-e396-62231a71a0e0@gmail.com> Date: Mon, 17 May 2021 17:46:12 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 5/17/21 5:22 AM, Jan Beulich wrote: > On 14.05.2021 20:53, Connor Davis wrote: >> Move struct grant_table; in grant_table.h above >> ifdef CONFIG_GRANT_TABLE. This fixes the following: >> >> /build/xen/include/xen/grant_table.h:84:50: error: 'struct grant_table' >> declared inside parameter list will not be visible outside of this >> definition or declaration [-Werror] >> 84 | static inline int mem_sharing_gref_to_gfn(struct grant_table *gt, >> | > There must be more to this, as e.g. the PV shim does get built with > !GRANT_TABLE. Nevertheless, ... > You are right... you're comment made me realize I had only tested this with XEN_TARGET_ARCH=riscv64. I will rework this. >> Signed-off-by: Connor Davis > ... since the potential of breaking the build is obvious enough, > Acked-by: Jan Beulich > > Jan Thanks, Connor