From: "flichtenheld (Code Review)" Date: Tue, 9 Jul 2024 12:57:25 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., selva.nair@...277..., openvpn-devel@lists.sourceforge.net Message-ID: <42e41c11f9bd78c27cdf2df33a167d19083ce785-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="BqMkyAerWkA="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Static-challenge concatenation option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: selvanair Cc: plaisthos , openvpn-devel --BqMkyAerWkA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos, selvanair. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/665?usp=3Demail ) Change subject: Static-challenge concatenation option ...................................................................... Patch Set 2: Code-Review-1 (2 comments) File doc/management-notes.txt: http://gerrit.openvpn.net/c/openvpn/+/665/comment/bf183267_3d352506 : PS2, Line 1333: FORMAT =3D bit 2 =3D 1 if response should be conca= tenated with password Honestly it is not clear to me from this documentation on how these flags c= ombine. Concatenate them? Binary addition? Please include an example. File src/openvpn/misc.h: http://gerrit.openvpn.net/c/openvpn/+/665/comment/49006d0b_8f0cea84 : PS2, Line 121: #define GET_USER_PASS_STATIC_CHALLENGE_CONCAT (1<<11) /* in= dicates password and response should be concatenated */ Please add a test to the UT suite test_get_user_pass_static_challenge -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/665?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I59a90446bfe73d8856516025a58a6f62cc98ab0d Gerrit-Change-Number: 665 Gerrit-PatchSet: 2 Gerrit-Owner: selvanair Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: selvanair Gerrit-Comment-Date: Tue, 09 Jul 2024 12:57:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --BqMkyAerWkA= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos, selvanair.

Patch set 2:Code-Review -1=

Vi= ew Change

2 comments:

  • File doc/management-notes.txt:<= /p>

    • Patch Set #2, Line = 1333: FORMAT = =3D bit 2 =3D 1 if response should be concatenated with password

      =

      Honestly it is n= ot clear to me from this documentation on how these flags combine. Concaten= ate them? Binary addition? Please include an example.

  • File src/openvpn/misc.h:

    • Patch Set #2, Line 121: #define GET_USER_PASS_STATIC_C= HALLENGE_CONCAT (1<<11) /* indicates password and response should be= concatenated */

      Please add a test to the UT suite test_get_user_pass_static_chal= lenge

To view, visit change 665. To unsubscribe, or fo= r help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I59a90446bfe73d8856516025a58= a6f62cc98ab0d
Gerrit-Change-Number: 665
Gerrit-PatchSet: 2
Gerrit-Owner: selvanair <selva.nair@...1354...= ..>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: selvanair <selva.nair@...493...= 277...>
Gerrit-Comment-Date: Tue, 09 Jul 2024 12:57:25= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--BqMkyAerWkA=--