From: Dan Magenheimer Subject: RE: [PATCH] linux-2.6.18-xen.hg: fix interaction of NTP and dom0->xen time updates Date: Wed, 18 Mar 2009 14:31:24 +0000 (GMT) Message-ID: <42eb677a-f409-4e02-bdd3-fac224d0344f@default> References: <20090318111410.GC11733@york.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=Windows-1252 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20090318111410.GC11733@york.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Tim Deegan , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Hi Tim -- Cool! Just checking... this provides improvement when: 1) the patch is applied to dom0 2) dom0 is running NTP 3) pv domU has independent_wallclock=3D0 4) pv domU is NOT running NTP Correct? Does it also help when: 1) the patch is applied to pv domU 2) pv domU has independent_wallclock=3D1 3) pv domU IS running NTP Are there any other configurations where it will help? Are there any configurations where it might cause problems? Thanks, Dan > -----Original Message----- > From: Tim Deegan [mailto:Tim.Deegan@citrix.com] > Sent: Wednesday, March 18, 2009 5:14 AM > To: xen-devel@lists.xensource.com > Subject: [Xen-devel] [PATCH] linux-2.6.18-xen.hg: fix=20 > interaction of NTP > and dom0->xen time updates >=20 >=20 > Don't discard NTP sync when updating Xen wallclock time from dom0, > as that's almost the first thing we do when we become synced. > Move the call to ntp_clear() into do_settimeofday(), which is the > only caller of __update_wallclock() that looks like it should break > NTP sync. =20 >=20 > This fixes the timer chain that sets Xen's wallclock every minute when > dom0 is NTP synced, which in turn greatly improves wallclock=20 > accuracy in > PV domU. >=20 > Signed-off-by: Tim Deegan >=20 > --=20 > Tim Deegan > Principal Software Engineer, Citrix Systems (R&D) Ltd. > [Company #02300071, SL9 0DZ, UK.] >