References: <20200701011018.31364-1-tincanteksup@...277...> From: tincanteksup Message-ID: <42f5a6bf-560f-e60e-e4ca-9b134b56d8b1@...277...> Date: Thu, 2 Jul 2020 14:50:00 +0100 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB Subject: Re: [Openvpn-devel] [Patch] New man page corrections - windows-options.rst List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: "Jonathan K. Bullard" Cc: openvpn-devel Hi Jonathan, these are going to the new manpage, see: https://gitlab.com/dazo/openvpn/-/tree/dev/man-reformatting They don't really need an ACK because dazo will review them first anyway but thanks all the same :) Regards On 02/07/2020 14:41, Jonathan K. Bullard wrote: > Improves English diction and/or grammar of man page. > > Acked-by: Jonathan K. Bullard > > On Tue, Jun 30, 2020 at 9:11 PM Richard Bonhomme wrote: >> >> Signed-off-by: Richard Bonhomme >> --- >> doc/man-sections/windows-options.rst | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/doc/man-sections/windows-options.rst b/doc/man-sections/windows-options.rst >> index 5ae7116c..72424d6b 100644 >> --- a/doc/man-sections/windows-options.rst >> +++ b/doc/man-sections/windows-options.rst >> @@ -231,7 +231,7 @@ Windows-Specific Options >> directive is not specified, OpenVPN will use the SystemRoot environment >> variable. >> >> - This option have changed behaviour in OpenVPN 2.3. Earlier you had to >> + This option has changed behaviour since OpenVPN 2.3. Earlier you had to >> define ``--win-sys env`` to use the SystemRoot environment variable, >> otherwise it defaulted to :code:`C:\\WINDOWS`. It is not needed to use >> the ``env`` keyword any more, and it will just be ignored. A warning is >> @@ -239,7 +239,7 @@ Windows-Specific Options >> >> --windows-driver drv >> Specifies which tun driver to use. Values are :code:`tap-windows6` >> - (default) and :code:`wintun`. This is Windows-only option. >> + (default) and :code:`wintun`. This is a Windows-only option. >> :code:`wintun`" requires ``--dev tun`` and the OpenVPN process to run >> elevated, or be invoked using the Interactive Service. >> >> -- >> 2.17.1 >> >> >> >> _______________________________________________ >> Openvpn-devel mailing list >> Openvpn-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/openvpn-devel