Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B371C433F5 for ; Mon, 14 Mar 2022 09:12:52 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 24A4383993; Mon, 14 Mar 2022 10:12:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=benettiengineering.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=aruba.it header.i=@aruba.it header.b="KBa0m6lX"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3564083B56; Mon, 14 Mar 2022 10:12:47 +0100 (CET) Received: from smtpcmd03117.aruba.it (smtpcmd03117.aruba.it [62.149.158.117]) by phobos.denx.de (Postfix) with ESMTP id C868D83929 for ; Mon, 14 Mar 2022 10:12:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=benettiengineering.com Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=giulio.benetti@benettiengineering.com Received: from [192.168.50.220] ([146.241.7.124]) by Aruba Outgoing Smtp with ESMTPSA id Tgkon1sPMPOoWTgkpnbceQ; Mon, 14 Mar 2022 10:12:40 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aruba.it; s=a1; t=1647249161; bh=s9hbycxKfmGq+VWpJr33ilg6Yrn4Owb/CDzhNWpywvo=; h=Date:MIME-Version:Subject:To:From:Content-Type; b=KBa0m6lXFGXKH6DWNn7KA5Ywws76uE4zLp0IW+Fo6v+3oqlNhn9G1DVkQjNncMYsh xnQ1U3QqYqoxoA4qthw1uucRT+7qh/wCZxHdwvENH8B/tNn30gqbWzcHesqmjBJcgI N2MwenmYg+fIxwH08pkDL3oBPuq4VPwpUl0UKWOC2xbzqVJTjysZd4tuSSTd7uPSCo ZKii7cnq6dC0L5FnvrqYyKeMScXeR3tHy7a48F6R1Dnzq+cS6R/8jOqdutmaw3/wQE fBBtK96KIitKaWnwbEdenH3nEtqYgVQ7j/e2ZLL29Pt9820gmUjzc/twvLZ5AxRIdG 669pJ0H1V2DaA== Message-ID: <4354313d-4e5c-1ba1-de83-45772aeb7e7e@benettiengineering.com> Date: Mon, 14 Mar 2022 10:12:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] drivers/adc/rockchip-saradc: remove double semi-colon Content-Language: en-US To: Kever Yang Cc: U-Boot-Denx References: <20220204011932.1414117-1-giulio.benetti@benettiengineering.com> From: Giulio Benetti In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CMAE-Envelope: MS4wfOiBUUNjv/Wwv9dPnCu9iMvPA9LdnnaB0JEXJw591zLwURBYv/YkZ7zn4FcvsMmJCpvbCELJOj0Qz3T6j+QbLJwHQRElKHq3qJKwHtIzS9RfMUqrXqlT +cSC1feV2veI+H/yaN1AGl/u/rHzScrCZ2Fbxo1Oa8lLa/Ed0g+4MbPDdK2UJUJMYx2Qh3D8vEU36LNA1ZGoC+Sx3nnhS2XknXYQrAacqWJGq88HV4eRhPCP X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 14/03/22 09:04, Kever Yang wrote: > Hi Giulio, > > Thanks for your patch, it's a good catching. > Could you please update the subject with "rockchip: adc: ", and > add a simple description in the commit message? Empy commit message is > not allowed according to U-Boot patch commit rules :( Oh, I've forgotten about this in u-boot. Just sent V2: https://patchwork.ozlabs.org/project/uboot/patch/20220314090943.821630-1-giulio.benetti@benettiengineering.com/ and tagged V1 as superseded in patchwork. Best regards -- Giulio Benetti Benetti Engineering sas > Thanks, > - Kever > > Giulio Benetti 于2022年2月4日周五 09:19写道: >> >> Signed-off-by: Giulio Benetti >> --- >> drivers/adc/rockchip-saradc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/adc/rockchip-saradc.c b/drivers/adc/rockchip-saradc.c >> index e464d33f22..e0cbab6aa0 100644 >> --- a/drivers/adc/rockchip-saradc.c >> +++ b/drivers/adc/rockchip-saradc.c >> @@ -131,7 +131,7 @@ int rockchip_saradc_of_to_plat(struct udevice *dev) >> } >> >> priv->data = data; >> - uc_pdata->data_mask = (1 << priv->data->num_bits) - 1;; >> + uc_pdata->data_mask = (1 << priv->data->num_bits) - 1; >> uc_pdata->data_format = ADC_DATA_FORMAT_BIN; >> uc_pdata->data_timeout_us = SARADC_TIMEOUT / 5; >> uc_pdata->channel_mask = (1 << priv->data->num_channels) - 1; >> -- >> 2.25.1 >>