Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 062C2C433E0 for ; Fri, 29 Jan 2021 11:50:00 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8D5364EDE for ; Fri, 29 Jan 2021 11:49:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8D5364EDE Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.78067.141854 (Exim 4.92) (envelope-from ) id 1l5SHb-0000V9-7b; Fri, 29 Jan 2021 11:49:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 78067.141854; Fri, 29 Jan 2021 11:49:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l5SHb-0000V2-4R; Fri, 29 Jan 2021 11:49:47 +0000 Received: by outflank-mailman (input) for mailman id 78067; Fri, 29 Jan 2021 11:49:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l5SHa-0000Ux-3t for xen-devel@lists.xenproject.org; Fri, 29 Jan 2021 11:49:46 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 06f59128-92ad-4a07-9828-0fc7b57f0d1c; Fri, 29 Jan 2021 11:49:43 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 03EBCAE53; Fri, 29 Jan 2021 11:49:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 06f59128-92ad-4a07-9828-0fc7b57f0d1c X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1611920983; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CVgn/p9vPivDO3a/olC5nMCPMnj0NzurvQDlNoJ25II=; b=HtAu8G0funnxAqXJBfUly4RfLqfqQuVvY+AwPeeEm2K1ETSC91v7aiMH4MHRE/ajWLHx5w gz/Bce/BDM/e4Lf/Nzx8XtLZbeHnk8A4iJ+MSLY0ADB9aGL62OVVfxsSnZgi7H4gEzVcln Pmqh8q8udx5Z+dVR0Gyo8i7JjDGrtos= Subject: Re: [PATCH v2 3/3] x86: Support booting under Secure Startup via SKINIT To: Andrew Cooper Cc: =?UTF-8?Q?Norbert_Kami=c5=84ski?= , Marek Kasiewicz , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Michal Zygowski , Piotr Krol , Krystian Hebel , "Daniel P . Smith" , Rich Persaud , Christopher Clark , Xen-devel References: <20210115231046.31785-1-andrew.cooper3@citrix.com> <20210129114510.30966-1-andrew.cooper3@citrix.com> From: Jan Beulich Message-ID: <436fcd27-ec06-3181-b236-fe0e75a5edcb@suse.com> Date: Fri, 29 Jan 2021 12:49:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210129114510.30966-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 29.01.2021 12:45, Andrew Cooper wrote: > From: Norbert Kamiński > > For now, this is simply enough logic to let Xen come up after the bootloader > has executed an SKINIT instruction to begin a Secure Startup. > > During a Secure Startup, the BSP operates with the GIF clear (blocks all > external interrupts, even SMI/NMI), and INIT_REDIRECTION active (converts INIT > IPIs to #SX exceptions, if e.g. the platform needs to scrub secrets before > resetting). To afford APs the same Secure Startup protections as the BSP, the > INIT IPI must be skipped, and SIPI must be the first interrupt seen. > > Full details are available in AMD APM Vol2 15.27 "Secure Startup with SKINIT" > > Introduce skinit_enable_intr() and call it from cpu_init(), next to the > enable_nmis() which performs a related function for tboot startups. > > Also introduce ap_boot_method to control the sequence of actions for AP boot. > > Signed-off-by: Marek Kasiewicz > Signed-off-by: Norbert Kamiński > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich