From: Matthew Dobson Date: Tue, 08 Nov 2005 19:04:27 +0000 Subject: [KJ] Re: [PATCH 4/8] Cleanup kmem_cache_create() Message-Id: <4370F6BB.1070409@us.ibm.com> List-Id: References: <436FF51D.8080509@us.ibm.com> <436FF70D.6040604@us.ibm.com> <52mzkfrily.fsf@cisco.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christoph Lameter Cc: Roland Dreier , kernel-janitors@lists.osdl.org, Pekka J Enberg , linux-kernel@vger.kernel.org Christoph Lameter wrote: > On Mon, 7 Nov 2005, Roland Dreier wrote: > > >> > * Replace a constant (4096) with what it represents (PAGE_SIZE) >> >>This seems dangerous. I don't pretend to understand the slab code, >>but the current code works on architectures with PAGE_SIZE != 4096. >>Are you sure this change is correct? > > > Leave the constant. The 4096 is only used for debugging and is a boundary > at which redzoning and last user accounting is given up. > > A large object in terms of this patch is a object greater than 4096 bytes > not an object greater than PAGE_SIZE. I think the absolute size is > desired. Would you be OK with at least NAMING the constant? I won't name it PAGE_SIZE (of course), but LARGE_OBJECT_SIZE or something? > Would you CC manfred on all your patches? Yes. I will repost my patches later today and I will be sure to CC Manfred on all of them. Thanks for the review, -Matt _______________________________________________ Kernel-janitors mailing list Kernel-janitors@lists.osdl.org https://lists.osdl.org/mailman/listinfo/kernel-janitors