From: "Jan Beulich" Subject: [PATCH] x86-64 linux: remove dead code Date: Wed, 08 Feb 2006 14:06:35 +0100 Message-ID: <43E9FAEB.76F0.0078.0@novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=__PartE5C742CB.0__=" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org This is a MIME message. If you are reading this text, you may want to consider changing to a mail reader or gateway that understands how to properly handle MIME multipart messages. --=__PartE5C742CB.0__= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Having stumbled across this a number of times now (recognizing each time that the code as is simply cannot work) I'd like to request removing the offending left-over pieces from native interrupt handling. Thanks, Jan --=__PartE5C742CB.0__= Content-Type: text/plain; name="xenlinux-x86_64-no-interrupt-entries.patch" Content-Transfer-Encoding: 8bit Content-Disposition: attachment; filename="xenlinux-x86_64-no-interrupt-entries.patch" --- head-2006-02-07.orig/arch/x86_64/kernel/entry-xen.S 2006-02-07 13:29:12.000000000 +0100 +++ head-2006-02-07/arch/x86_64/kernel/entry-xen.S 2006-02-08 11:43:17.000000000 +0100 @@ -492,42 +492,10 @@ ENTRY(stub_rt_sigreturn) #define XCPT_FRAME _frame ORIG_RAX /* - * Interrupt entry/exit. + * Interrupt exit. * - * Interrupt entry points save only callee clobbered registers in fast path. - * - * Entry runs with interrupts off. */ -/* 0(%rsp): interrupt number */ - .macro interrupt func - cld -#ifdef CONFIG_DEBUG_INFO - SAVE_ALL - movq %rsp,%rdi - /* - * Setup a stack frame pointer. This allows gdb to trace - * back to the original stack. - */ - movq %rsp,%rbp - CFI_DEF_CFA_REGISTER rbp -#else - SAVE_ARGS - leaq -ARGOFFSET(%rsp),%rdi # arg1 for handler -#endif -#if 0 /* For Xen we don't need to do this */ - testl $3,CS(%rdi) - je 1f - swapgs -#endif -1: incl %gs:pda_irqcount # RED-PEN should check preempt count - movq %gs:pda_irqstackptr,%rax - cmoveq %rax,%rsp /*todo This needs CFI annotation! */ - pushq %rdi # save old stack - CFI_ADJUST_CFA_OFFSET 8 - call \func - .endm - retint_check: movl threadinfo_flags(%rcx),%edx andl %edi,%edx @@ -639,7 +597,6 @@ ENTRY(invalidate_interrupt\num) ENTRY(call_function_interrupt) apicinterrupt CALL_FUNCTION_VECTOR,smp_call_function_interrupt #endif -#endif /* !CONFIG_XEN */ #ifdef CONFIG_X86_LOCAL_APIC ENTRY(apic_timer_interrupt) @@ -651,6 +608,7 @@ ENTRY(error_interrupt) ENTRY(spurious_interrupt) apicinterrupt SPURIOUS_APIC_VECTOR,smp_spurious_interrupt #endif +#endif /* !CONFIG_XEN */ /* * Exception entry points. --=__PartE5C742CB.0__= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --=__PartE5C742CB.0__=--