From: "Jan Beulich" Subject: [PATCH] x86-64 linux: another adjustment to vmalloc fault handling Date: Fri, 17 Feb 2006 11:38:51 +0100 Message-ID: <43F5B5CB.76F0.0078.0@novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=__PartD2F069AB.0__=" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org This is a MIME message. If you are reading this text, you may want to consider changing to a mail reader or gateway that understands how to properly handle MIME multipart messages. --=__PartD2F069AB.0__= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Changeset 8847 improved things, but doesn't generally work. We namely experienced problems (when we originally tried the same change) with accesses to machine_to_phys_mapping, which (in mfn_to_pfn) is specifically allowed to fault. Hence there should not be attempts to fix up faults within the hypervisor range (as for any page table entries obtained there no m2p translation exists for the guest, resulting in bogus physical addresses getting used for further fault processing, frequently leading to nested faults). Jan --=__PartD2F069AB.0__= Content-Type: text/plain; name="xenlinux-x86_64-vmalloc_fault.patch" Content-Transfer-Encoding: 8bit Content-Disposition: attachment; filename="xenlinux-x86_64-vmalloc_fault.patch" --- a/linux-2.6-xen-sparse/arch/x86_64/mm/fault-xen.c Thu Feb 16 11:25:36 2006 +0000 +++ b/linux-2.6-xen-sparse/arch/x86_64/mm/fault-xen.c Thu Feb 16 11:30:44 2006 +0000 @@ -371,7 +371,7 @@ asmlinkage void __kprobes do_page_fault( * entries. */ if (!(error_code & (PF_RSVD|PF_USER|PF_PROT)) && - address >= PAGE_OFFSET) { + address >= HYPERVISOR_VIRT_END) { if (vmalloc_fault(address) < 0) goto bad_area_nosemaphore; return; --=__PartD2F069AB.0__= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --=__PartD2F069AB.0__=--