From: "Jan Beulich" Subject: Re: [PATCH, updated] i386 linux: eliminate hard coded items from __xen_guest section Date: Mon, 20 Feb 2006 17:15:44 +0100 Message-ID: <43F9F940.76F0.0078.0@novell.com> References: <43F35CB6.76F0.0078.0@novell.com> <43F5B633.76F0.0078.0@novell.com> <3d8eece20602200804y7f00ed55s40706f768fd99ae2@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <3d8eece20602200804y7f00ed55s40706f768fd99ae2@mail.gmail.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Christian.Limpach@cl.cam.ac.uk Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Hmm, I would assume your assembler then only does 32-bit calculations. In that case (if such assemblers still exist), I'd rather want to use the same macro as on 64-bits, where a similar problem needed to be worked around. Jan >>> christian.limpach@gmail.com 20.02.06 17:04:35 >>> On 2/17/06, Jan Beulich wrote: > To allow the new VMSPLIT_* Kconfig options to work, and to avoid problems when the position of the hypercall page > changes, this patch eliminates the hard-coded entries in the __xen_guest section in head.S. > Unfortunately the original version didn't work with gas newer than beginning of August 2005, where in an attempt to fix > another problem a regression was introduced. The calculation doesn't seem to work on 32-bit for PAGE_OFFSET >= 2^31, at least not with: cl349@firebug:~/ls/xen-unstable-clean.hg$ as --version GNU assembler 2.15.92.0.2 20040927 I'll checkin the following: .macro bigutoa value utoa (\value) >> 12 .ascii "000" .endm .macro utoa value .if (\value) >= 16 utoa (\value) >> 4 .endif .if (\value) % 16 < 10 .byte '0' + (\value) % 16 .else .byte 'A' + (\value) % 16 - 10 .endif .endm .section __xen_guest .ascii "GUEST_OS=linux,GUEST_VER=2.6" .ascii ",XEN_VER=xen-3.0" .ascii ",VIRT_BASE=0x"; bigutoa __PAGE_OFFSET .ascii ",HYPERCALL_PAGE=0x"; utoa ((__PHYSICAL_START+HYPERCALL_PAGE_OFFSET)>>PAGE_SHIFT) It's a bit gross, maybe there's a neater solution. christian