From: "Mike D. Day" Subject: Re: [ PATCH 2.6.16-rc3-xen 3/3] sysfs: export Xen hypervisor attributes to sysfs Date: Tue, 21 Feb 2006 12:48:43 -0500 Message-ID: <43FB527B.5030404@us.ibm.com> References: <43FB2642.7020109@us.ibm.com> <1140542130.8693.18.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1140542130.8693.18.camel@localhost.localdomain> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Dave Hansen Cc: Greg KH , xen-devel@lists.xensource.com, lkml List-Id: xen-devel@lists.xenproject.org Dave Hansen wrote: > It could be: > > +---sys > +---hypervisor > +---type > +---version > +---major > +---minor > +---extra > Yeah, the type file could be useful. >> +static ssize_t extra_show(struct kobject * kobj, >> + struct attribute * attr, >> + char * page) >> +{ >> + char extra_ver[XENVER_EXTRAVERSION_LEN]; > > At 1k, this is a wee bit too big to be on the stack. I'd just kmalloc > it instead. This particular constant is 16 bytes so I'll leave it as is. The other one (CAPABILTIES_INFO), which is 1k, I did kmalloc as you suggested. >> +static void xen_compilation_destroy(void) >> +{ >> + sysfs_remove_group(c_kobj, &xen_compilation_group); >> + kobject_put(c_kobj); >> + return; >> +} > > Yup, this is another excellent function name. I'll change the others to be as descriptive. Thanks, Mike Day