From: Simon Goldschmidt Date: Mon, 11 Feb 2019 22:00:06 +0100 Subject: [U-Boot] [U-Boot,v2,11/23] spl: Add a comment to spl_set_bd() In-Reply-To: <20181109184319.GZ11247@bill-the-cat> References: <20181002112253.202931-12-sjg@chromium.org> <20181109184319.GZ11247@bill-the-cat> Message-ID: <43a3ed3d-49fe-359b-a583-6bb277c0f563@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Am 09.11.2018 um 19:43 schrieb Tom Rini: > On Tue, Oct 02, 2018 at 05:22:41AM -0600, Simon Glass wrote: > >> There is a strange feature to set global_data to a data-section variable >> early in SPL. This only works if SPL actually has access to SRAM which is >> not the case on x86, for eaxmple. Add a comment to this effect. Seems like I missed that one back in October. Does anyone have an idea why this variable ('static bd_t bdata') is hard-coded into section ".data"? To me this seems pretty unportable... For example, for a specific feature on socfpga (warm reboot CRC check), I would prefer to have the ".data" section empty and put 'bdata' into bss. This is currently not possible. But before sending a patch that somehow changes this behaviour, I'd like to know why this variable is put into ".data" instead of ".bss" Thanks, Simon >> >> Signed-off-by: Simon Glass > > Reviewed-by: Tom Rini