Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1iP8j1-00071Y-M8 for mharc-grub-devel@gnu.org; Mon, 28 Oct 2019 13:22:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48678) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iP8iy-0006xn-GV for grub-devel@gnu.org; Mon, 28 Oct 2019 13:22:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iP8iw-000783-JZ for grub-devel@gnu.org; Mon, 28 Oct 2019 13:22:35 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:49513 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iP8iw-00077O-G8 for grub-devel@gnu.org; Mon, 28 Oct 2019 13:22:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572283353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YXiWti/wjCxg7td7t52MF5Z4uH6oQdxPN2KFepoNyjc=; b=c0LGewFIFcicquwtSqwbc4aDSDoAvQOX0jfcIyg439pwLUsqq5pm5ROzjL4MqaVpTznwGb nBFe1xF4T7PkRgVtSptwURE1pa5atQJYuxSsq08qTc3Vlaj7yms597bJMAiQJXNJxjE54K s4lPv8c4OUms1blMXinDFGhyMED1JTU= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-267-RgnR-63lNP-c9bmN1k7aJg-1; Mon, 28 Oct 2019 13:22:30 -0400 Received: by mail-wr1-f70.google.com with SMTP id x9so6761811wrq.5 for ; Mon, 28 Oct 2019 10:22:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=r55vpEjSLGJJPYLIapIWj7qOdYNojvqe0ftG61t79nI=; b=gcLYiojlsb3gQlJ9UT1VRZGGV38fbW9wyw4hFpFMbG0J5LCqDaF3yY5ts8z+EbKTRV 9SbW7UTwUsBqpYkVwyMJes08VPu9RBeVj2ALrfnuuwogIdB27vMsq5Mkmc2yUUPhnGHq FSJVHAGJ+0OQcTNvojcs5oTd9dctk6bQv3RWNTW8QpwY+nwiuQbSOeJqof84ltNy8oN7 bgqkM1MlKfTHwaIzdeLVEOb9CJCo4SCx84hzFpwo4Dzee0yRhS0tRaEr9hANTG1a3H1D kenY1Ie68IVaCRvW6Z11ApIuP2kiJi7Gr1iQSi98tQcwPl8CcJdMqJiW60RFT5TQo9Xy gC2A== X-Gm-Message-State: APjAAAWGSbBMhHKfvuNIX5HQUmsOxuftfV+dS5Gq+NB2IAmFpJyCoUUo L1/b21tgR3YVKfuzonG9D3eajZHFzHWj8wGhN87/V7ObVdDHC1BDRV1qZXpIaD0mFPegs3mt/2z TmVLgYKUuu8M= X-Received: by 2002:a1c:a78b:: with SMTP id q133mr312448wme.115.1572283349112; Mon, 28 Oct 2019 10:22:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqwVmV0ZT996ObzybtxM3e/S07j8MPc5bWyKqHj2tYpjj5VNYqAI5gT7gM+0B9cg/1JJ7Q1l7Q== X-Received: by 2002:a1c:a78b:: with SMTP id q133mr312440wme.115.1572283348903; Mon, 28 Oct 2019 10:22:28 -0700 (PDT) Received: from [192.168.1.13] ([90.168.169.92]) by smtp.gmail.com with ESMTPSA id 143sm246095wmb.33.2019.10.28.10.22.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Oct 2019 10:22:28 -0700 (PDT) Subject: Re: [PATCH v4 4/5] normal/main: Search for specific config files for netboot To: Daniel Kiper Cc: grub-devel@gnu.org, Vladimir Serbinenko , Daniel Kiper , Paulo Flabiano Smorigo References: <20191023130034.12834-1-javierm@redhat.com> <20191023130034.12834-5-javierm@redhat.com> <20191028151305.kvsq5trw6g5p5ffd@tomti.i.net-space.pl> From: Javier Martinez Canillas Message-ID: <43d1d1de-c00d-62bf-e44d-b48ed9658db6@redhat.com> Date: Mon, 28 Oct 2019 18:22:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <20191028151305.kvsq5trw6g5p5ffd@tomti.i.net-space.pl> Content-Language: en-US X-MC-Unique: RgnR-63lNP-c9bmN1k7aJg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Oct 2019 17:22:38 -0000 On 10/28/19 4:13 PM, Daniel Kiper wrote: > On Wed, Oct 23, 2019 at 03:00:32PM +0200, Javier Martinez Canillas wrote: >> From: Paulo Flabiano Smorigo >> >> This patch implements a search for a specific configuration when the con= fig >> file is on a remoteserver. It uses the following order: >> 1) DHCP client UUID option. >> 2) MAC address (in lower case hexadecimal with dash separators); >> 3) IP (in upper case hexadecimal) or IPv6; >> 4) The original grub.cfg file. >> >> This procedure is similar to what is used by pxelinux and yaboot: >> http://www.syslinux.org/wiki/index.php/PXELINUX#config >> >> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=3D873406 >> >> Signed-off-by: Paulo Flabiano Smorigo >> Signed-off-by: Javier Martinez Canillas >> Reviewed-by: Daniel Kiper >=20 > Did you at least build test whole patchset? I do not think so. > Please do that before posting any patch on grub-devel. I do not > accept any patch which at least does not build. Details below.. I do build and test the functionality for all the posted patches but just noticed that I was calling configure with the --disable-werror option on my build script... and that's why I missed these issues. Sorry about that, I fixed my script now so it won't happen again. > Plus some nitpicks... > I'll address these also in v5, thanks again for your feedback and review. =20 Best regards, --=20 Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat