From: "plaisthos (Code Review)" Date: Mon, 7 Jul 2025 14:05:56 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., gianmarco@...2726..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <43f5a57500bdc4aad48a9b409d225d6770a81dd5-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="q6pALGOkBvs="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Multi-socket: Fix assert triggered by stale peer-id reuse List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: its_Giaan Cc: flichtenheld , openvpn-devel --q6pALGOkBvs= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, its_Giaan. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c= /openvpn/+/1078?usp=3Demail ) Change subject: Multi-socket: Fix assert triggered by stale peer-id reuse ...................................................................... Patch Set 1: Code-Review-1 (2 comments) Patchset: PS1: The check for NULL after already accessing it, looks very fishy. File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/1078/comment/5cf6ed60_e43a0b88 : PS1, Line 225: if (mi) This looks fishy. This basically can never fail. Since we already access `m= ->instances[peer_id]` in the if condition, this would have already segfault= ed before even getting to this if (mi) check -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1078?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iecbbcf32c0059f2b16a05333b3794599060d7d6a Gerrit-Change-Number: 1078 Gerrit-PatchSet: 1 Gerrit-Owner: its_Giaan Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: its_Giaan Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Mon, 07 Jul 2025 14:05:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --q6pALGOkBvs= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, its_Giaan.

Patch set 1:Code-Review -1=

V= iew Change

2 comments:

  • Patchset:

    • Patch Set #1:

      The check for NULL after already accessing = it, looks very fishy.

  • Patch Set #1, Line 225: if (mi)

    This looks fishy. This basically can nev= er fail. Since we already access `m->instances[peer_id]` in the if condi= tion, this would have already segfaulted before even getting to this if (mi= ) check

To view, visit change 1078. To unsubscribe, o= r for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iecbbcf32c0059f2b16a05333b37= 94599060d7d6a
Gerrit-Change-Number: 1078
Gerrit-PatchSet: 1
Gerrit-Owner: its_Giaan <gianmarco@...2786...= ..>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: its_Giaan <gianmarco@...1665...= 726...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Mon, 07 Jul 2025 14:05:56= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--q6pALGOkBvs=--