From: "stipa (Code Review)"
Date: Thu, 31 Jul 2025 12:19:28 +0000
In-Reply-To:
References:
Reply-To: lstipakov@...277..., arne-openvpn@...1227..., heiko@...515...,
openvpn-devel@lists.sourceforge.net, frank@...2641...
Message-ID: <44090afcefc412ce6e3498685dd39827b6124444-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="/7gHS3QOW8c="; charset=UTF-8
Subject: [Openvpn-devel] [S] Change in openvpn[master]: Fix DNS options
duplication on PUSH_UPDATE
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: d12fk , plaisthos , flichtenheld , openvpn-devel
--/7gHS3QOW8c=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: d12fk, flichtenheld, plaisthos.
stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/ope=
nvpn/+/1121?usp=3Demail )
Change subject: Fix DNS options duplication on PUSH_UPDATE
......................................................................
Patch Set 2:
(4 comments)
Commit Message:
http://gerrit.openvpn.net/c/openvpn/+/1121/comment/0cd9cff6_537c22be :
PS2, Line 18: were added to existing once instead of overwriting them.
> *existing ones
Acknowledged
http://gerrit.openvpn.net/c/openvpn/+/1121/comment/4febbb73_89ff723d :
PS2, Line 22: - reseting tuntap DNS options (regression from abovementione=
d commit)
> *resetting
Acknowledged
File src/openvpn/options.c:
http://gerrit.openvpn.net/c/openvpn/+/1121/comment/d5dc85c6_45b16c8c :
PS2, Line 3548: if (s)
> s will never be NULL here, in that case we'd branched to /* Copy --dhcp-o=
ptions to tuntap_options */ [=E2=80=A6]
Acknowledged
http://gerrit.openvpn.net/c/openvpn/+/1121/comment/472f0a8d_8ef94cd9 :
PS2, Line 6227:
> This code should instead store the DNS related things in `options->dns_op=
tions.from_dhcp`. [=E2=80=A6]
but we don't store anything here - just nullifying tuntap_options and calli=
ng add_option(), which does the right thing by storing data in from_dhcp.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1121?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ife4d8fc5f8e2183e61226d66a76bbaa02c06f787
Gerrit-Change-Number: 1121
Gerrit-PatchSet: 2
Gerrit-Owner: stipa
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: d12fk
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: flichtenheld
Gerrit-Attention: d12fk
Gerrit-Comment-Date: Thu, 31 Jul 2025 12:19:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: d12fk
Gerrit-MessageType: comment
--/7gHS3QOW8c=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: d12fk, flichtenheld, plaisthos. <=
/p>
View =
Change
4 comments:
<=
p style=3D"white-space: pre-wrap; word-wrap: break-word;">Acknowledged<=
/li>Patch Set #2, Line 22: - reseting tuntap DNS options (regression from abovementione=
d commit)
*resetting
Acknowledged
<=
li style=3D"margin: 0; padding: 0;">File src/openvpn/options.c:
Patch Set #2, Line 3548:=
a> if (s)
=
s will never be NULL here, in that case we'd branched to /* Co=
py --dhcp-options to tuntap_options */ [=E2=80=A6]
Acknowledged
Patch Set #2, Line 6227:
This code should instead store the DNS rela=
ted things in `options->dns_options.from_dhcp`. [=E2=80=A6]
=
but we don=
39;t store anything here - just nullifying tuntap_options and calling add_o=
ption(), which does the right thing by storing data in from_dhcp.
<=
/ul>
To view, visit change 1121. To unsubscribe, or for help writin=
g mail filters, visit settin=
gs.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ife4d8fc5f8e2183e61226d66a76=
bbaa02c06f787
Gerrit-Change-Number: 1121
Gerrit-PatchSet: 2
Gerrit-Owner: stipa <lstipakov@...277...>=
;
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: d12fk <heiko@...515...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Attention: d12fk <heiko@...515...>=
;
Gerrit-Comment-Date: Thu, 31 Jul 2025 12:19:28=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: d12fk <heiko@...515...=
>
Gerrit-MessageType: comment
--/7gHS3QOW8c=--