From: "cron2 (Code Review)" Date: Fri, 8 Aug 2025 05:58:27 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <44115989071d65dcba02428137874eba5fa3fccb-EmailReplacePatchSet-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="bqLHu9CWqvg="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: t_client.sh: Do not wait 3 seconds for OpenVPN to come up List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , plaisthos Cc: openvpn-devel --bqLHu9CWqvg= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#3) to the change originally created by= flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1139?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: t_client.sh: Do not wait 3 seconds for OpenVPN to come up ...................................................................... t_client.sh: Do not wait 3 seconds for OpenVPN to come up On most machines 1 second should be quite enough. Given that we run currently 23 tests on most t_client runs, this makes over 40 seconds difference. Not nothing. We keep the existing 30s maximum wait-time since sometimes we want to do tests with intentionally slow servers. Change-Id: Ice8c7ff4d8118a9e6465a4724207a355138360b8 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Message-Id: <20250807203741.31359-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32= 585.html Signed-off-by: Gert Doering --- M tests/t_client.sh.in 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/39/1139/3 diff --git a/tests/t_client.sh.in b/tests/t_client.sh.in index 7a271b6..a49de40 100755 --- a/tests/t_client.sh.in +++ b/tests/t_client.sh.in @@ -377,13 +377,13 @@ $RUN_SUDO "${openvpn}" $openvpn_conf >>$LOGDIR/$SUF:openvpn.log & sudopid=3D$! - # Check if OpenVPN has initialized before continuing. It will check e= very 3rd second up + # Check if OpenVPN has initialized before continuing. It will check e= very second up # to $ovpn_init_check times. - ovpn_init_check=3D10 + ovpn_init_check=3D30 ovpn_init_success=3D0 while [ $ovpn_init_check -gt 0 ]; do - sleep 3 # Wait for OpenVPN to initialize and have had time to writ= e the pid file + sleep 1 # Wait for OpenVPN to initialize and have had time to writ= e the pid file grep "Initialization Sequence Completed" $LOGDIR/$SUF:openvpn.log >= /dev/null if [ $? -eq 0 ]; then ovpn_init_check=3D0 -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1139?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ice8c7ff4d8118a9e6465a4724207a355138360b8 Gerrit-Change-Number: 1139 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: newpatchset --bqLHu9CWqvg= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 uploaded patch set #3 to the change originally cr= eated by flichtenheld.

View Change

The following approvals got outd= ated and were removed: Code-Review+2 by cron2

t_client.sh: Do not wait 3 seconds for OpenVPN to co=
me up

On most machines 1 second should be quite enough. Given
tha= t we run currently 23 tests on most t_client runs, this
makes over 40 se= conds difference. Not nothing.

We keep the existing 30s maximum wait= -time since sometimes
we want to do tests with intentionally slow server= s.

Change-Id: Ice8c7ff4d8118a9e6465a4724207a355138360b8
Signed-of= f-by: Frank Lichtenheld <frank@...2641...>
Acked-by: Gert Doering = <gert@...1296...>
Message-Id: <20250807203741.31359-1-gert@...1386...= 296...>
URL: https://www.mail-archive.com/openvpn-devel@...1535...= orge.net/msg32585.html
Signed-off-by: Gert Doering <gert@...1296...&g= t;
---
M tests/t_client.sh.in
1 file changed, 3 insertions(+), 3 d= eletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/=
changes/39/1139/3
diff --git a/tests/t_client.sh.in b/tests/t_clien=
t.sh.in
index 7a271b6..a49de40 100755
--- a= /tests/t_client.sh.in
+++ b/tests/t_client.sh.in
= @@ -377,13 +377,13 @@
$RUN_SUDO "${openvpn}= " $openvpn_conf >>$LOGDIR/$SUF:openvpn.log &
sudopid=3D$!

- # Check if OpenVPN has initialized before continuing. I= t will check every 3rd second up
+ # Check if OpenVPN has initialized before continuing. It = will check every second up
# to $ovpn_init_check times= .
- ovpn_init_check= =3D10
+ ovpn_init_= check=3D30
ovpn_init_success=3D0
= while [ $ovpn_init_check -gt 0 ];
do
- sleep 3 # Wait for OpenVPN to i= nitialize and have had time to write the pid file
+ sleep 1 # Wait for OpenVPN to initial= ize and have had time to write the pid file
grep &q= uot;Initialization Sequence Completed" $LOGDIR/$SUF:openvpn.log >/d= ev/null
if [ $? -eq 0 ]; then
= ovpn_init_check=3D0

To view, vis= it chang= e 1139. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ice8c7ff4d8118a9e6465a472420= 7a355138360b8
Gerrit-Change-Number: 1139
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: newpatchset
--bqLHu9CWqvg=--