From: "Jan Beulich" Subject: Re: [PATCH] i386 linux: make 32-bit PAE kernel work when built with newer gcc Date: Tue, 14 Mar 2006 11:40:25 +0100 Message-ID: <4416ABA9.76F0.0078.0@novell.com> References: <4415AE7C.76F0.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org >>> Keir Fraser 14.03.06 11:09:29 >>> > >On 13 Mar 2006, at 16:40, Jan Beulich wrote: > >> The compiler isn't required to order the two stores >> ptep_get_and_clear_full() in any particular way, and we saw cases >> where the upper 32 bits get stored before the lower ones, which causes >> the access to fail (page-fault propagated out of >> Xen). > >Won't this need a barrier() (compile barrier) between the updates of >low and high portions? No, I can't see why. The compiler isn't permitted to re-order separate writes across sequence points (which is different from a single 64-bit write, where the compiler is only expected to carry out the full 64-bit write prior to the next sequence point, but nothing requires it to do this in any particular order). Jan