From: Zachary Amsden Subject: Re: [RFC, PATCH 5/24] i386 Vmi code patching Date: Wed, 15 Mar 2006 08:01:28 -0800 Message-ID: <44183A58.10506@vmware.com> References: <200603131802.k2DI2nv8005665@zach-dev.vmware.com> <20060315100210.GU12807@sorel.sous-sol.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20060315100210.GU12807@sorel.sous-sol.org> Sender: linux-kernel-owner@vger.kernel.org To: Chris Wright Cc: Linus Torvalds , Linux Kernel Mailing List , Virtualization Mailing List , Xen-devel , Andrew Morton , Dan Hecht , Dan Arai , Anne Holler , Pratap Subrahmanyam , Christopher Li , Joshua LeVasseur , Chris Wright , Rik Van Riel , Jyothy Reddy , Jack Lo , Kip Macy , Jan Beulich , Ky Srinivasan , Wim Coekaerts , Leendert van Doorn List-Id: xen-devel@lists.xenproject.org Chris Wright wrote: > * Zachary Amsden (zach@vmware.com) wrote: > >> +static void fixup_translation(struct vmi_annotation *a) >> +{ >> + unsigned char *c, *start, *end; >> + int left; >> + >> + memcpy(a->nativeEIP, a->translationEIP, a->translation_size); >> + start = a->nativeEIP; >> + end = a->nativeEIP + a->translation_size; >> + >> + for (c = start; c < end;) { >> + switch(*c) { >> + case MNEM_CALL_NEAR: >> >> > Why these restrictions? How do you do int $0x82, for example? > We don't. This is the minimal set of instructions that are emitted during the annotation. The instruction sequence is only sufficient to call out to the hypervisor ROM. What we want to do next is to allow the hypervisor itself to do this code fixup - in effect, relinking in the local translations, which in many cases would then convert to int $0x82 for inline Xen calls. Zach