From: Daniel Arai Subject: Re: [RFC, PATCH 1/24] i386 Vmi documentation Date: Wed, 15 Mar 2006 14:56:23 -0800 Message-ID: <44189B97.2040802@vmware.com> References: <200603131759.k2DHxeep005627@zach-dev.vmware.com> <20060313224902.GD12807@sorel.sous-sol.org> <4416078C.4030705@vmware.com> <20060314212742.GL12807@sorel.sous-sol.org> <441743BD.1070108@vmware.com> <20060315025720.GN12807@sorel.sous-sol.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20060315025720.GN12807@sorel.sous-sol.org> Sender: linux-kernel-owner@vger.kernel.org To: Chris Wright Cc: Zachary Amsden , Linus Torvalds , Linux Kernel Mailing List , Virtualization Mailing List , Xen-devel , Andrew Morton , Dan Hecht , Anne Holler , Pratap Subrahmanyam , Christopher Li , Joshua LeVasseur , Rik Van Riel , Jyothy Reddy , Jack Lo , Kip Macy , Jan Beulich , Ky Srinivasan , Wim Coekaerts , Leendert van Doorn List-Id: xen-devel@lists.xenproject.org Chris Wright wrote: > * Zachary Amsden (zach@vmware.com) wrote: > >>>1) can't use stack based args, so have to allocate each data structure, >>>which could conceivably fail unless it's some fixed buffer. >> >>We use a fixed buffer that is private to our VMI layer. It's a per-cpu >>packing struct for hypercalls. Dynamically allocating from the kernel >>inside the interface layer is a really great way to get into a whole lot >>of trouble. > > > Heh, indeed that's why I asked. per-cpu buffer means ROM state knows > which vcpu is current. How is this done in OS agnostic method w/out > trapping to hypervisor? Some shared data that ROM and VMM know about, > and VMM updates as it schedules each vcpu? Each VCPU gets a private data area at the same linear address. The VMM constructs private page table shadows for each VCPU, and the shadows magically contain the right mappings for that VCPU's private data area. Other hypervisor implementations (especially those that don't make use of shadow page tables) would have to come up with something along the lines that you're suggesting. Dan.