From: Zachary Amsden Subject: Re: [RFC, PATCH 14/24] i386 Vmi reboot fixes Date: Wed, 15 Mar 2006 15:24:14 -0800 Message-ID: <4418A21E.6030704@vmware.com> References: <200603131809.k2DI9slZ005727@zach-dev.vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "Eric W. Biederman" Cc: Linus Torvalds , Linux Kernel Mailing List , Virtualization Mailing List , Xen-devel , Andrew Morton , Dan Hecht , Dan Arai , Anne Holler , Pratap Subrahmanyam , Christopher Li , Joshua LeVasseur , Chris Wright , Rik Van Riel , Jyothy Reddy , Jack Lo , Kip Macy , Jan Beulich , Ky Srinivasan , Wim Coekaerts , Leendert van Doorn List-Id: xen-devel@lists.xenproject.org Eric W. Biederman wrote: > Zachary Amsden writes: > Huh? Rebooting through the BIOS and kexec are pretty much mutually exclusive. > Looking at the patch I can't see what you are talking about either. > Let me rephrase - kexec doesn't define calls for machine_shutdown and others that are in arch/i386/kernel/reboot.c. So kexec requires BIOS reboot code to be compiled in, even though the usage of the two is mutually exclusive. > Does kexec successfully work under VMWare? > It should work just fine. But it could expose bugs on either end. I've been monitoring our kexec testing, and I'll be able to help you with any issues that we might find on the Linux side. :) > machine_halt does not want to stop the processor. It is very much > about killing the kernel and user space but having the software still > linger a little. > I was afraid of that. I can back that change out. The problem I had was that the shutdown code I was running in userspace would not make the syscalls to actually call machine_power_off, but machine_halt instead. Will fix. Zach