Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5CC410A1E68 for ; Thu, 26 Mar 2026 11:16:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 570A910E29C; Thu, 26 Mar 2026 11:16:11 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="VFyIZu6h"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id EC83710E1EA; Thu, 26 Mar 2026 11:16:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774523769; x=1806059769; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=vIkZywfa+OVyVuE0a5fZx+v9A+FDIFGGNs46i2+6fc0=; b=VFyIZu6hUG4mDuU/TiQXlPDDXUsmF46WkvxaPsppWPjUNoHFa7n6LlUm RiJTDMzxN4WXnPU7ROfbGU3KshrP+IQhTGK1W6WfyyHUIKYnCq7p8KQPg awYl/w5IWz9u6nha1uZyopxo5+Xr8IjPmQlul3YPhDJuwjp37eaW53Nom OZrMEyxUmiHk0pDQH0gv4LRtC7vOkD6OcLwQncWSAq9Kfr9KXfonL8Q2I ES9YGvt9falUuyGGKWNo3tG6IwW48HkVibtqmvhOg5Fx5wR8ESaEfqLt6 +WFAHY9aGkty+DMFEqIeAZXHIHIqHGyOuQpgO2z+G7ThJmdNh3Yky/8EJ w==; X-CSE-ConnectionGUID: jqLIQOuvS2Wb6UsMM1ee1w== X-CSE-MsgGUID: NIqRrAgLR1K1NVcV99SeTQ== X-IronPort-AV: E=McAfee;i="6800,10657,11740"; a="75646356" X-IronPort-AV: E=Sophos;i="6.23,142,1770624000"; d="scan'208";a="75646356" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2026 04:15:54 -0700 X-CSE-ConnectionGUID: gOEKJZGaQm2yQBkolGgQ+A== X-CSE-MsgGUID: OKX5A21dTlmIVHHX3aIJhQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,142,1770624000"; d="scan'208";a="221669838" Received: from carterle-desk.ger.corp.intel.com (HELO localhost) ([10.245.246.184]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2026 04:15:51 -0700 From: Jani Nikula To: Ville Syrjala , intel-gfx@lists.freedesktop.org Cc: intel-xe@lists.freedesktop.org Subject: Re: [PATCH 03/12] drm/i915/mchbar: Define the end of the MCHBAR mirror In-Reply-To: <20260325185342.11482-4-ville.syrjala@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20260325185342.11482-1-ville.syrjala@linux.intel.com> <20260325185342.11482-4-ville.syrjala@linux.intel.com> Date: Thu, 26 Mar 2026 13:15:46 +0200 Message-ID: <441c648b13c7cb03478a373a4b48cf6954c1c1d0@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 25 Mar 2026, Ville Syrjala wrote: > From: Ville Syrj=C3=A4l=C3=A4 > > Add defines for the end of the MCHBAR mirror. I'm planning to > use this for some range sanity checks. > > BSpec: 51771 > Signed-off-by: Ville Syrj=C3=A4l=C3=A4 Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_mchbar_regs.h | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_mchbar_regs.h b/drivers/gpu/drm/i= 915/intel_mchbar_regs.h > index 614d4017b57b..ca0d421be16c 100644 > --- a/drivers/gpu/drm/i915/intel_mchbar_regs.h > +++ b/drivers/gpu/drm/i915/intel_mchbar_regs.h > @@ -16,11 +16,16 @@ > * every way. It is not accessible from the CP register read instructio= ns. > * > * Starting from Haswell, you can't write registers using the MCHBAR mir= ror, > - * just read. > + * just read. On MTL+ the mirror no longer exists. > */ >=20=20 > #define MCHBAR_MIRROR_BASE 0x10000 > +#define MCHBAR_MIRROR_END 0x13fff > + > #define MCHBAR_MIRROR_BASE_SNB 0x140000 > +#define MCHBAR_MIRROR_END_SNB 0x147fff > +#define MCHBAR_MIRROR_END_ICL_RKL 0x14ffff > +#define MCHBAR_MIRROR_END_TGL 0x15ffff >=20=20 > #define CTG_STOLEN_RESERVED _MMIO(MCHBAR_MIRROR_BASE + 0x34) > #define ELK_STOLEN_RESERVED _MMIO(MCHBAR_MIRROR_BASE + 0x48) --=20 Jani Nikula, Intel