From: Zachary Amsden Subject: Re: [RFC, PATCH 10/24] i386 Vmi descriptor changes Date: Wed, 22 Mar 2006 16:00:43 -0800 Message-ID: <4421E52B.2040503@vmware.com> References: <200603131806.k2DI6jlJ005700@zach-dev.vmware.com> <200603222124.03284.ak@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200603222124.03284.ak@suse.de> Sender: linux-kernel-owner@vger.kernel.org To: Andi Kleen Cc: virtualization@lists.osdl.org, Linus Torvalds , Linux Kernel Mailing List , Xen-devel , Andrew Morton , Dan Hecht , Dan Arai , Anne Holler , Pratap Subrahmanyam , Christopher Li , Joshua LeVasseur , Chris Wright , Rik Van Riel , Jyothy Reddy , Jack Lo , Kip Macy , Jan Beulich , Ky Srinivasan , Wim Coekaerts , Leendert van Doorn List-Id: xen-devel@lists.xenproject.org Andi Kleen wrote: >> -#define _set_gate(gate_addr,type,dpl,addr,seg) \ >> -do { \ >> - int __d0, __d1; \ >> - __asm__ __volatile__ ("movw %%dx,%%ax\n\t" \ >> - "movw %4,%%dx\n\t" \ >> - "movl %%eax,%0\n\t" \ >> - "movl %%edx,%1" \ >> - :"=m" (*((long *) (gate_addr))), \ >> - "=m" (*(1+(long *) (gate_addr))), "=&a" (__d0), "=&d" (__d1) \ >> - :"i" ((short) (0x8000+(dpl<<13)+(type<<8))), \ >> - "3" ((char *) (addr)),"2" ((seg) << 16)); \ >> -} while (0) >> > > > The ugly piece of code doesn't do anything priviledged. So why do you want > to move it? > > I didn't think I moved it. I wrote a clean version instead. It does do something problematic for virtualization, by not allowing the VMI layer to override the DPL on descriptors or RPL of segments. It might be convenient for the hypervisor platform layer to do that. Zach