From: Nick Piggin Subject: Re: [RFC PATCH 30/35] Add generic_page_range() function Date: Thu, 23 Mar 2006 11:15:54 +1100 Message-ID: <4421E8BA.2010807@yahoo.com.au> References: <20060322063040.960068000@sorel.sous-sol.org> <20060322063805.741915000@sorel.sous-sol.org> <44213333.6030404@yahoo.com.au> <79fcd3fd1d13741c5d1cd3c6f5b326b9@cl.cam.ac.uk> <503082446ce33efbf163ad2af63bb0e1@cl.cam.ac.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <503082446ce33efbf163ad2af63bb0e1@cl.cam.ac.uk> Sender: linux-kernel-owner@vger.kernel.org To: Keir Fraser Cc: virtualization@lists.osdl.org, xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org, Ian Pratt , Chris Wright List-Id: xen-devel@lists.xenproject.org Keir Fraser wrote: > > On 22 Mar 2006, at 14:33, Keir Fraser wrote: > >> Okay, can you suggest a better one? That's the best I could come up >> with that wasn't long winded. > > > How about apply_to_page_range()? > That would be better. >> >>> secondly, I think you confuse our (confusing) terminology: the page >>> that holds pte_ts is not the pte_page, the pte_page is the page that >>> a pte points to >> >> >> What should we call it? Essentially we want to be able to get the >> physical address of a PTE in some cases, and passing struct page >> pointer seemed the best way to be able to derive that. I can rename it >> to something else vaguely plausible if the only problem is the >> semantic clash with Linux's idiomatic use of pte_page. > > > Looks like pmd_page is correct? > Yes... although maybe you could just pass the 'pmd_t *'? That's what a lot of the mm/memory.c code does. -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com