Message-ID: <44258b51-41a7-8d81-e362-c399e069f476@...1227...> Date: Thu, 3 Mar 2022 15:08:25 +0100 MIME-Version: 1.0 Content-Language: en-GB References: <20220301135054.277-1-lstipakov@...277...> From: Arne Schwabe In-Reply-To: <20220301135054.277-1-lstipakov@...277...> Subject: Re: [Openvpn-devel] [PATCH] Fix incorrect default mssfix value in server mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: Lev Stipakov , openvpn-devel@lists.sourceforge.net Cc: Lev Stipakov Am 01.03.22 um 14:50 schrieb Lev Stipakov: > From: Lev Stipakov > > When calculating default mssfix, we take into account > protocol overhead, which usually includes 3 bytes peer-id. > > Peer-id usage is indicated by options->use_peer_id flag. > In client mode it is set when applying pushed options. > In server mode it is not set and as a result mssfix value > is 3 bytes off. > > Fix by setting this flag in multi.c when calculating > tunnel-specific options. Acked-By: Arne Schwabe This fixes the issue at hand. It would be better to refactor the whole peerid in use signalling eventually but this is good enough for now. Arne