From: zhoucm1 Subject: Re: [PATCH] drm: fix call_kern.cocci warnings Date: Thu, 25 Oct 2018 16:53:43 +0800 Message-ID: <4429acda-a5cd-f919-388f-ab4a67abc260@amd.com> References: <20181025083634.7178-1-david1.zhou@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20181025083634.7178-1-david1.zhou@amd.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chunming Zhou , dri-devel@lists.freedesktop.org Cc: =?UTF-8?Q?Christian_K=c3=b6nig?= , intel-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org cGxzIGlnbm9yZSB0aGlzIG9uZSwgcGxlYXNlIHJldmlldyB2Mi4KCgoKT24gMjAxOOW5tDEw5pyI MjXml6UgMTY6MzYsIENodW5taW5nIFpob3Ugd3JvdGU6Cj4gZHJpdmVycy9ncHUvZHJtL2RybV9z eW5jb2JqLmM6MjAyOjQtMTQ6IEVSUk9SOiBmdW5jdGlvbiBkcm1fc3luY29ial9maW5kX3NpZ25h bF9wdF9mb3JfcG9pbnQgY2FsbGVkIG9uIGxpbmUgMzkwIGluc2lkZSBsb2NrIG9uIGxpbmUgMzg5 IGJ1dCB1c2VzIEdGUF9LRVJORUwKPgo+ICAgIEZpbmQgZnVuY3Rpb25zIHRoYXQgcmVmZXIgdG8g R0ZQX0tFUk5FTCBidXQgYXJlIGNhbGxlZCB3aXRoIGxvY2tzIGhlbGQuCj4KPiBTZW1hbnRpYyBw YXRjaCBpbmZvcm1hdGlvbjoKPiAgICBUaGUgcHJvcG9zZWQgY2hhbmdlIG9mIGNvbnZlcnRpbmcg dGhlIEdGUF9LRVJORUwgaXMgbm90IG5lY2Vzc2FyaWx5IHRoZQo+ICAgIGNvcnJlY3Qgb25lLiAg SXQgbWF5IGJlIGRlc2lyZWQgdG8gdW5sb2NrIHRoZSBsb2NrLCBvciB0byBub3QgY2FsbCB0aGUK PiAgICBmdW5jdGlvbiB1bmRlciB0aGUgbG9jayBpbiB0aGUgZmlyc3QgcGxhY2UuCj4KPiBHZW5l cmF0ZWQgYnk6IHNjcmlwdHMvY29jY2luZWxsZS9sb2Nrcy9jYWxsX2tlcm4uY29jY2kKPgo+IFNp Z25lZC1vZmYtYnk6IENodW5taW5nIFpob3UgPGRhdmlkMS56aG91QGFtZC5jb20+Cj4gQ2M6IE1h YXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6 IGludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBDYzogQ2hyaXN0aWFuIEvDtm5pZyA8 ZWFzeTJyZW1lbWJlci5jaGtAZ29vZ2xlbWFpbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9k cm0vZHJtX3N5bmNvYmouYyB8IDEyICsrKysrKy0tLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDYg aW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vZHJtX3N5bmNvYmouYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fc3luY29iai5jCj4gaW5k ZXggYjdlYWE2MDNmMzY4Li5jOTA5OTU0OWRkY2IgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2RybV9zeW5jb2JqLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3N5bmNvYmouYwo+ IEBAIC0xMTEsNiArMTExLDcgQEAgc3RhdGljIHN0cnVjdCBkbWFfZmVuY2UKPiAgIAkJCQkgICAg ICB1aW50NjRfdCBwb2ludCkKPiAgIHsKPiAgIAlzdHJ1Y3QgZHJtX3N5bmNvYmpfc2lnbmFsX3B0 ICpzaWduYWxfcHQ7Cj4gKwlzdHJ1Y3QgZG1hX2ZlbmNlICpmZW5jZSA9IE5VTEw7Cj4gICAKPiAg IAlpZiAoKHN5bmNvYmotPnR5cGUgPT0gRFJNX1NZTkNPQkpfVFlQRV9USU1FTElORSkgJiYKPiAg IAkgICAgKHBvaW50IDw9IHN5bmNvYmotPnRpbWVsaW5lKSkgewo+IEBAIC0xMzEsMTUgKzEzMiwx OCBAQCBzdGF0aWMgc3RydWN0IGRtYV9mZW5jZQo+ICAgCQlyZXR1cm4gJmZlbmNlLT5iYXNlOwo+ ICAgCX0KPiAgIAo+ICsJc3Bpbl9sb2NrKCZzeW5jb2JqLT5wdF9sb2NrKTsKPiAgIAlsaXN0X2Zv cl9lYWNoX2VudHJ5KHNpZ25hbF9wdCwgJnN5bmNvYmotPnNpZ25hbF9wdF9saXN0LCBsaXN0KSB7 Cj4gICAJCWlmIChwb2ludCA+IHNpZ25hbF9wdC0+dmFsdWUpCj4gICAJCQljb250aW51ZTsKPiAg IAkJaWYgKChzeW5jb2JqLT50eXBlID09IERSTV9TWU5DT0JKX1RZUEVfQklOQVJZKSAmJgo+ICAg CQkgICAgKHBvaW50ICE9IHNpZ25hbF9wdC0+dmFsdWUpKQo+ICAgCQkJY29udGludWU7Cj4gLQkJ cmV0dXJuIGRtYV9mZW5jZV9nZXQoJnNpZ25hbF9wdC0+ZmVuY2VfYXJyYXktPmJhc2UpOwo+ICsJ CWZlbmNlID0gZG1hX2ZlbmNlX2dldCgmc2lnbmFsX3B0LT5mZW5jZV9hcnJheS0+YmFzZSk7Cj4g KwkJYnJlYWs7Cj4gICAJfQo+IC0JcmV0dXJuIE5VTEw7Cj4gKwlzcGluX3VubG9jaygmc3luY29i ai0+cHRfbG9jayk7Cj4gKwlyZXR1cm4gZmVuY2U7Cj4gICB9Cj4gICAKPiAgIHN0YXRpYyB2b2lk IGRybV9zeW5jb2JqX2FkZF9jYWxsYmFja19sb2NrZWQoc3RydWN0IGRybV9zeW5jb2JqICpzeW5j b2JqLAo+IEBAIC0xNjYsOSArMTcwLDcgQEAgc3RhdGljIHZvaWQgZHJtX3N5bmNvYmpfZmVuY2Vf Z2V0X29yX2FkZF9jYWxsYmFjayhzdHJ1Y3QgZHJtX3N5bmNvYmogKnN5bmNvYmosCj4gICAJfQo+ ICAgCj4gICAJbXV0ZXhfbG9jaygmc3luY29iai0+Y2JfbXV0ZXgpOwo+IC0Jc3Bpbl9sb2NrKCZz eW5jb2JqLT5wdF9sb2NrKTsKPiAgIAkqZmVuY2UgPSBkcm1fc3luY29ial9maW5kX3NpZ25hbF9w dF9mb3JfcG9pbnQoc3luY29iaiwgcHRfdmFsdWUpOwo+IC0Jc3Bpbl91bmxvY2soJnN5bmNvYmot PnB0X2xvY2spOwo+ICAgCWlmICghKmZlbmNlKQo+ICAgCQlkcm1fc3luY29ial9hZGRfY2FsbGJh Y2tfbG9ja2VkKHN5bmNvYmosIGNiLCBmdW5jKTsKPiAgIAltdXRleF91bmxvY2soJnN5bmNvYmot PmNiX211dGV4KTsKPiBAQCAtMzc5LDExICszODEsOSBAQCBkcm1fc3luY29ial9wb2ludF9nZXQo c3RydWN0IGRybV9zeW5jb2JqICpzeW5jb2JqLCB1NjQgcG9pbnQsIHU2NCBmbGFncywKPiAgIAkJ aWYgKHJldCA8IDApCj4gICAJCQlyZXR1cm4gcmV0Owo+ICAgCX0KPiAtCXNwaW5fbG9jaygmc3lu Y29iai0+cHRfbG9jayk7Cj4gICAJKmZlbmNlID0gZHJtX3N5bmNvYmpfZmluZF9zaWduYWxfcHRf Zm9yX3BvaW50KHN5bmNvYmosIHBvaW50KTsKPiAgIAlpZiAoISpmZW5jZSkKPiAgIAkJcmV0ID0g LUVJTlZBTDsKPiAtCXNwaW5fdW5sb2NrKCZzeW5jb2JqLT5wdF9sb2NrKTsKPiAgIAlyZXR1cm4g cmV0Owo+ICAgfQo+ICAgCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWwK