From: "Jan Beulich" Subject: Re: [PATCH] linux: xenbus_be currently doesn't build properly as a module Date: Thu, 20 Apr 2006 15:33:15 +0200 Message-ID: <4447A9BB.76E4.0078.0@novell.com> References: <44479695.76E4.0078.0@novell.com> <88c3dae3cc8a048a507a1a3549475c65@cl.cam.ac.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <88c3dae3cc8a048a507a1a3549475c65@cl.cam.ac.uk> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org >>> Keir Fraser 20.04.06 15:08:28 >>> > >On 20 Apr 2006, at 13:11, Jan Beulich wrote: > >> It depends on the non-exported symbols vmlist and vmlist_lock. As >> exporting these doesn't seem reasonable, the patch >> disables the ability to build this as a module for now. >> >> Signed-off-by: Jan Beulich > >A better fix is for xenbus_map_ring_valloc() to have the prototype: >struct vm_struct *xenbus_map_ring_valloc(struct xenbus_device *, int); > >It then returns the vmarea that is allocated, or ERR_PTR() on error. > >Then xenbus_unmap_ring_vfree() takes the vmarea rather than vaddr and >we avoid the nasty vmlist scan that cannot be modularised. > >There's only one user of these functions right now, so the patch for >this proper fix won't be very big. I specifically didn't do it this proper way because of the comment in the function saying doing it the raw way would be so much simpler - but if that in fact doesn't apply... Jan