From: "Jan Beulich" Subject: Re: [PATCH] fxsave/fxrstor adjustments Date: Tue, 25 Apr 2006 08:54:10 +0200 Message-ID: <444DE3B2.76E4.0078.0@novell.com> References: <444D0B62.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com, Andreas Kleen List-Id: xen-devel@lists.xenproject.org >>> Keir Fraser 24.04.06 18:14 >>> > >On 24 Apr 2006, at 16:31, Jan Beulich wrote: > >> This patch addresses CVE-2006-1056 (information leak from >> fxsave/fxrstor on AMD CPUs) and also adjusts 64-bit handling >> so that full 64-bit RIP/RDP values get saved/restored. More >> fine-grained handling may be needed if 32-bit processes are >> expected to properly see their selectors (native Linux doesn't >> currently do that either, but there is a patch to adjust >> it there). > >Why does this patch (and the one in Linux 2.6.16.9) use 'emms' in the >fxsave path rather than 'ffree st(7)' which is what AMD recommends in >their published advisory? Is the former faster? I just cloned what Andi did for 32- and 64-bit Linux. Andi? Jan