From: Marek Vasut Date: Sun, 29 Nov 2020 13:49:14 +0100 Subject: [PATCH v4 1/2] pinctrl: renesas: Make sure the pin type is updated after setting the MUX In-Reply-To: <20201128131309.13895-2-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20201128131309.13895-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20201128131309.13895-2-prabhakar.mahadev-lad.rj@bp.renesas.com> Message-ID: <44548193-fed4-69d4-0e9c-2728c88aa4ae@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 11/28/20 2:13 PM, Lad Prabhakar wrote: > By default on startup all the pin types are configured to > PINMUX_TYPE_NONE (in sh_pfc_map_pins()), when pin is set as GPIO the > pin type is updated to PINMUX_TYPE_GPIO. But the type is not updated > when the pin is set as a function in sh_pfc_pinctrl_pin_set() or > sh_pfc_pinctrl_group_set() calls (these calls only set the MUX if > the pin type is PINMUX_TYPE_NONE ie unused). > > So with the current implementation pin functionality could be overwritten > silently, for example if the same pin is added for SPI and serial. > > This patch makes sure of updating pin type after every successful call to > sh_pfc_config_mux() and thus fixing from pin functionality to be > overwritten. Also a warning message is printed if the current pin is being > overwritten before abort. > > This also avoids pin re-muxing to same type that is for example from > command line device is asked to re-probe/select (mmc dev x) we return > early with success in this case as the pin is already muxed. Applied, thanks