From: "Jan Beulich" Subject: [PATCH] adjust performance counter printing Date: Tue, 02 May 2006 16:21:27 +0200 Message-ID: <44578707.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=__PartE6C3F8F7.0__=" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org This is a MIME message. If you are reading this text, you may want to consider changing to a mail reader or gateway that understands how to properly handle MIME multipart messages. --=__PartE6C3F8F7.0__= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline This patch conditionalizes some output from perfc_printall(), thus making relevant information more compact and easier legible. It additionally changes the formatting so that trailing spaces are avoided. Also changing the type of some variables from plain int to unsigned int, as that is yielding more efficient code on x86-64 (signed 32-bit array indices require explicit sign extension, whereas in most cases an extra copy can be avoided when the index type is unsigned, since all 32-bit operations already zero-extend their results). Signed-off-by: Jan Beulich --=__PartE6C3F8F7.0__= Content-Type: text/plain; name="xen-perfc-formatting.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="xen-perfc-formatting.patch" --- 2006-04-27/xen/common/perfc.c.0 2006-04-06 17:50:26.000000000 +0200 +++ 2006-04-27/xen/common/perfc.c 2006-05-02 15:49:42.000000000 +0200 @@ -37,7 +37,7 @@ struct perfcounter perfcounters; void perfc_printall(unsigned char key) { - int i, j, sum; + unsigned int i, j, sum; s_time_t now = NOW(); atomic_t *counters = (atomic_t *)&perfcounters; @@ -59,22 +59,28 @@ void perfc_printall(unsigned char key) sum = 0; for_each_online_cpu ( j ) sum += atomic_read(&counters[j]); - printk("TOTAL[%10d] ", sum); - for_each_online_cpu ( j ) - printk("CPU%02d[%10d] ", j, atomic_read(&counters[j])); + printk("TOTAL[%10u]", sum); + if (sum) + { + for_each_online_cpu ( j ) + printk(" CPU%02d[%10d]", j, atomic_read(&counters[j])); + } counters += NR_CPUS; break; case TYPE_ARRAY: case TYPE_S_ARRAY: for ( j = sum = 0; j < perfc_info[i].nr_elements; j++ ) sum += atomic_read(&counters[j]); - printk("TOTAL[%10d] ", sum); + printk("TOTAL[%10u]", sum); #ifdef PERF_ARRAYS - for ( j = 0; j < perfc_info[i].nr_elements; j++ ) + if (sum) { - if ( (j != 0) && ((j % 4) == 0) ) - printk("\n "); - printk("ARR%02d[%10d] ", j, atomic_read(&counters[j])); + for ( j = 0; j < perfc_info[i].nr_elements; j++ ) + { + if ( (j % 4) == 0 ) + printk("\n "); + printk(" ARR%02d[%10d]", j, atomic_read(&counters[j])); + } } #endif counters += j; @@ -90,7 +96,7 @@ void perfc_printall(unsigned char key) void perfc_reset(unsigned char key) { - int i, j; + unsigned int i, j; s_time_t now = NOW(); atomic_t *counters = (atomic_t *)&perfcounters; --=__PartE6C3F8F7.0__= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --=__PartE6C3F8F7.0__=--