From: "Martin J. Bligh" Subject: Re: [RFC PATCH 00/35] Xen i386 paravirtualization support Date: Tue, 09 May 2006 07:49:37 -0700 Message-ID: <4460AC01.5020503@mbligh.org> References: <20060509084945.373541000@sous-sol.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20060509084945.373541000@sous-sol.org> Sender: linux-kernel-owner@vger.kernel.org To: Chris Wright Cc: linux-kernel@vger.kernel.org, virtualization@lists.osdl.org, xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Congrats on getting this thrashed out. A few comments, most of which are boring style nits, but nonetheless ... will try to take a proper look later. General comment: Why is this style used: HYPERVISOR_foo_bar ? ie the capitalization of HYPERVISOR. Doesn't seem to fit with the rest of the kernel style.