From: Nick Piggin Subject: Re: [RFC PATCH 15/35] subarch support for controlling interrupt delivery Date: Wed, 10 May 2006 00:55:01 +1000 Message-ID: <4460AD45.4070608@yahoo.com.au> References: <20060509084945.373541000@sous-sol.org> <20060509085154.095325000@sous-sol.org> <4460AC06.4000303@mbligh.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4460AC06.4000303@mbligh.org> Sender: linux-kernel-owner@vger.kernel.org To: "Martin J. Bligh" Cc: Chris Wright , linux-kernel@vger.kernel.org, virtualization@lists.osdl.org, xen-devel@lists.xensource.com, Ian Pratt List-Id: xen-devel@lists.xenproject.org Martin J. Bligh wrote: >> +/* >> + * The use of 'barrier' in the following reflects their use as >> local-lock >> + * operations. Reentrancy must be prevented (e.g., __cli()) /before/ >> following >> + * critical operations are executed. All critical operations must >> complete >> + * /before/ reentrancy is permitted (e.g., __sti()). Alpha >> architecture also >> + * includes these barriers, for example. >> + */ > > > Seems like an odd comment to have in an i386 header file. Also, it is only talking about compiler barriers, which have nothing to do with the architecture. And preempt_* macros should contain the correct compiler barriers, so several can be removed. -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com