From: Avi Kivity Subject: Re: [RFC PATCH 17/35] Segment register changes for Xen Date: Thu, 11 May 2006 13:34:34 +0300 Message-ID: <4463133A.8060806@argo.co.il> References: <20060509084945.373541000@sous-sol.org> <20060509085154.802230000@sous-sol.org> <20060509071640.GA4150@ucw.cz> <200605102209.05004.ak@suse.de> <20060510203015.GA13949@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20060510203015.GA13949@elf.ucw.cz> Sender: linux-kernel-owner@vger.kernel.org To: Pavel Machek Cc: Andi Kleen , virtualization@lists.osdl.org, Chris Wright , xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org, Ian Pratt List-Id: xen-devel@lists.xenproject.org Pavel Machek wrote: > Really? If someone does > > if (something) > clearsegment(seg) > somethingelse(); > > ... he'll get very confusing behaviour instead of compile error. > > Okay, that's weaker argument than expected... > > Also clearsegment(x) clearsegment(y); will compile when it should not. > > Also clearsegment(i++) will behave strangely. So perhaps > > #define clearsegment(seg) do { seg; } while (0) > static inline void clearsegment(int seg) {} ? -- error compiling committee.c: too many arguments to function