From: Nick Piggin Subject: Re: [RFC PATCH 29/35] Add the Xen virtual console driver. Date: Sat, 13 May 2006 22:51:11 +1000 Message-ID: <4465D63F.4000605@yahoo.com.au> References: <20060509084945.373541000@sous-sol.org> <20060509085159.285105000@sous-sol.org> <20060513052757.59446e03.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20060513052757.59446e03.akpm@osdl.org> Sender: linux-kernel-owner@vger.kernel.org To: Andrew Morton Cc: Chris Wright , linux-kernel@vger.kernel.org, virtualization@lists.osdl.org, xen-devel@lists.xensource.com, ian.pratt@xensource.com, Christian.Limpach@cl.cam.ac.uk List-Id: xen-devel@lists.xenproject.org Andrew Morton wrote: >>+static void kcons_write_dom0( >>+ struct console *c, const char *s, unsigned int count) >>+{ >>+ int rc; >>+ >>+ while ((count > 0) && >>+ ((rc = HYPERVISOR_console_io( >>+ CONSOLEIO_write, count, (char *)s)) > 0)) { >>+ count -= rc; >>+ s += rc; >>+ } >>+} > > > must.. not.. mention.. coding.. style.. Someone should write you a script to go through a patch and flag the most common style mistakes. Have the output formatted to look like you're replying to the mail, and wire it up to your inbox ;) -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com