From: Nick Piggin Subject: Re: [PATCH 0/13: eCryptfs] eCryptfs Patch Set Date: Sun, 14 May 2006 12:59:30 +1000 Message-ID: <44669D12.5050306@yahoo.com.au> References: <20060513033742.GA18598@hellewell.homeip.net> <44655ECD.10404@yahoo.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: Phillip Hellewell , Andrew Morton , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, viro@ftp.linux.org.uk, mike@halcrow.us, mhalcrow@us.ibm.com, mcthomps@us.ibm.com, toml@us.ibm.com, yoder1@us.ibm.com, James Morris , "Stephen C. Tweedie" , Erez Zadok , David Howells Return-path: Received: from smtp102.mail.mud.yahoo.com ([209.191.85.212]:54419 "HELO smtp102.mail.mud.yahoo.com") by vger.kernel.org with SMTP id S932361AbWENC7i (ORCPT ); Sat, 13 May 2006 22:59:38 -0400 To: Michael Thompson In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Michael Thompson wrote: > On 5/12/06, Nick Piggin wrote: >> BTW. I'm not sure if linux-fsdevel has different conventions; however >> usually you don't break up a patch according to files, but logical >> components or transformations from one "sane" kernel tree to the next. >> And that means things keep compiling and working. > > > The files themselves are broken down into logical components, so the > per-file patch approach seems reasonable to me. Half a filesystem is a logical component? At the very least it wires up all the kconfig stuff _first_, so it breaks the tree from about patch 3 until 13. > >> Sometimes big patches are justified. > > > This patch format (a whole repost) was requested. I don't know that whole repost means break up the patches per-file... Logical might be 1: whole filesystem; 2: debug file+debug calls throughout 1; 3: documentation. -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com