From: "Charles Coffing" Subject: [PATCH] Check allocations when starting HVM domains Date: Thu, 18 May 2006 14:42:43 -0400 Message-ID: <446C6C73.D169.003C.0@novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=__PartB3969633.0__=" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org --=__PartB3969633.0__= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Several page allocations, done in the hypervisor when starting an HVM domain, are not checked. This can cause the physical machine to crash when starting the HVM domain during low-memory conditions. One patch is against xen-3.0-testing; the other is for xen-unstable. Kudos to Charles Arnold for catching the problem with shadow_direct_map_init. Signed-off-by: Charles Coffing Thanks. --=__PartB3969633.0__= Content-Type: application/octet-stream; name="xen302-hvm-alloc-check.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="xen302-hvm-alloc-check.diff" SW5kZXg6IHhlbi0zLjAtdGVzdGluZy94ZW4vYXJjaC94ODYvaHZtL2h2bS5jCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIHhlbi0zLjAtdGVzdGluZy5vcmlnL3hlbi9hcmNoL3g4Ni9odm0vaHZtLmMKKysrIHhlbi0z LjAtdGVzdGluZy94ZW4vYXJjaC94ODYvaHZtL2h2bS5jCkBAIC0xODksNyArMTg5LDExIEBAIHZv aWQgaHZtX3NldHVwX3BsYXRmb3JtKHN0cnVjdCBkb21haW4qIGQKICAgICBpZiAoICFodm1fZ3Vl c3QoY3VycmVudCkgfHwgKGN1cnJlbnQtPnZjcHVfaWQgIT0gMCkgKQogICAgICAgICByZXR1cm47 CiAKLSAgICBzaGFkb3dfZGlyZWN0X21hcF9pbml0KGQpOworICAgIGlmICggc2hhZG93X2RpcmVj dF9tYXBfaW5pdChkKSA9PSAwICkKKyAgICB7CisgICAgICAgIHByaW50aygiQ2FuIG5vdCBhbGxv Y2F0ZSBzaGFkb3cgZGlyZWN0IG1hcCBmb3IgSFZNIGRvbWFpbi5cbiIpOworICAgICAgICBkb21h aW5fY3Jhc2hfc3luY2hyb25vdXMoKTsKKyAgICB9CiAKICAgICBodm1fbWFwX2lvX3NoYXJlZF9w YWdlKGQpOwogICAgIGh2bV9nZXRfaW5mbyhkKTsKSW5kZXg6IHhlbi0zLjAtdGVzdGluZy94ZW4v YXJjaC94ODYvaHZtL3N2bS9zdm0uYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSB4ZW4tMy4wLXRlc3Rpbmcub3Jp Zy94ZW4vYXJjaC94ODYvaHZtL3N2bS9zdm0uYworKysgeGVuLTMuMC10ZXN0aW5nL3hlbi9hcmNo L3g4Ni9odm0vc3ZtL3N2bS5jCkBAIC00NTEsNiArNDUxLDkgQEAgaW50IHN0YXJ0X3N2bSh2b2lk KQogICAgIAogICAgIGlmICghKHRlc3RfYml0KFg4Nl9GRUFUVVJFX1NWTUUsICZib290X2NwdV9k YXRhLng4Nl9jYXBhYmlsaXR5KSkpCiAgICAgICAgIHJldHVybiAwOworICAgIGhvc3Rfc2F2ZV9h cmVhWyBjcHUgXSA9IGFsbG9jX2hvc3Rfc2F2ZV9hcmVhKCk7CisgICAgaWYgKCEgaG9zdF9zYXZl X2FyZWFbIGNwdSBdKQorICAgICAgICByZXR1cm4gMDsKICAgICAKICAgICByZG1zcihNU1JfRUZF UiwgZWF4LCBlZHgpOwogICAgIGVheCB8PSBFRkVSX1NWTUU7CkBAIC00NTksNyArNDYyLDYgQEAg aW50IHN0YXJ0X3N2bSh2b2lkKQogICAgIHByaW50aygiQU1EIFNWTSBFeHRlbnNpb24gaXMgZW5h YmxlZCBmb3IgY3B1ICVkLlxuIiwgY3B1ICk7CiAKICAgICAvKiBJbml0aWFsaXplIHRoZSBIU0Eg Zm9yIHRoaXMgY29yZSAqLwotICAgIGhvc3Rfc2F2ZV9hcmVhWyBjcHUgXSA9IGFsbG9jX2hvc3Rf c2F2ZV9hcmVhKCk7CiAgICAgcGh5c19oc2EgPSAodTY0KSB2aXJ0X3RvX21hZGRyKCBob3N0X3Nh dmVfYXJlYVsgY3B1IF0gKTsgCiAgICAgcGh5c19oc2FfbG8gPSAodTMyKSBwaHlzX2hzYTsKICAg ICBwaHlzX2hzYV9oaSA9ICh1MzIpIChwaHlzX2hzYSA+PiAzMik7ICAgIApJbmRleDogeGVuLTMu MC10ZXN0aW5nL3hlbi9hcmNoL3g4Ni9odm0vc3ZtL3ZtY2IuYwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSB4ZW4t My4wLXRlc3Rpbmcub3JpZy94ZW4vYXJjaC94ODYvaHZtL3N2bS92bWNiLmMKKysrIHhlbi0zLjAt dGVzdGluZy94ZW4vYXJjaC94ODYvaHZtL3N2bS92bWNiLmMKQEAgLTE0MywxOCArMTQzLDIxIEBA IHN0YXRpYyBpbnQgY29uc3RydWN0X3ZtY2JfY29udHJvbHMoc3RydWMKIAogICAgIC8qIFRoZSBm b2xsb3dpbmcgaXMgZm9yIEkvTyBhbmQgTVNSIHBlcm1pc2lvbiBtYXAgKi8KICAgICBpb3BtID0g YWxsb2NfeGVuaGVhcF9wYWdlcyhnZXRfb3JkZXJfZnJvbV9ieXRlcyhJT1BNX1NJWkUpKTsKLQot ICAgIEFTU0VSVChpb3BtKTsKLSAgICBtZW1zZXQoaW9wbSwgMHhmZiwgSU9QTV9TSVpFKTsKLSAg ICBjbGVhcl9iaXQoUENfREVCVUdfUE9SVCwgaW9wbSk7CisgICAgaWYgKGlvcG0pCisgICAgewor ICAgICAgICBtZW1zZXQoaW9wbSwgMHhmZiwgSU9QTV9TSVpFKTsKKyAgICAgICAgY2xlYXJfYml0 KFBDX0RFQlVHX1BPUlQsIGlvcG0pOworICAgIH0KICAgICBtc3JwbSA9IGFsbG9jX3hlbmhlYXBf cGFnZXMoZ2V0X29yZGVyX2Zyb21fYnl0ZXMoTVNSUE1fU0laRSkpOwotCi0gICAgQVNTRVJUKG1z cnBtKTsKLSAgICBtZW1zZXQobXNycG0sIDB4ZmYsIE1TUlBNX1NJWkUpOworICAgIGlmIChtc3Jw bSkKKyAgICAgICAgbWVtc2V0KG1zcnBtLCAweGZmLCBNU1JQTV9TSVpFKTsKIAogICAgIGFyY2hf c3ZtLT5pb3BtID0gaW9wbTsKICAgICBhcmNoX3N2bS0+bXNycG0gPSBtc3JwbTsKIAorICAgIGlm ICghIGlvcG0gfHwgISBtc3JwbSkKKyAgICAgICAgcmV0dXJuIDE7CisKICAgICB2bWNiLT5pb3Bt X2Jhc2VfcGEgPSAodTY0KSB2aXJ0X3RvX21hZGRyKGlvcG0pOwogICAgIHZtY2ItPm1zcnBtX2Jh c2VfcGEgPSAodTY0KSB2aXJ0X3RvX21hZGRyKG1zcnBtKTsKIAo= --=__PartB3969633.0__= Content-Type: application/octet-stream; name="xenunstable-hvm-alloc-check.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="xenunstable-hvm-alloc-check.diff" ZGlmZiAtcnUgYS94ZW4vYXJjaC94ODYvaHZtL2h2bS5jIHhlbi11bnN0YWJsZS5oZy94ZW4vYXJj aC94ODYvaHZtL2h2bS5jCi0tLSBhL3hlbi9hcmNoL3g4Ni9odm0vaHZtLmMJMjAwNi0wNS0xOCAx MjoxODozNC4wMDAwMDAwMDAgLTA2MDAKKysrIHhlbi11bnN0YWJsZS5oZy94ZW4vYXJjaC94ODYv aHZtL2h2bS5jCTIwMDYtMDUtMTggMTI6MjQ6MjEuMDAwMDAwMDAwIC0wNjAwCkBAIC0xODksNyAr MTg5LDExIEBACiAgICAgaWYgKCAhaHZtX2d1ZXN0KGN1cnJlbnQpIHx8IChjdXJyZW50LT52Y3B1 X2lkICE9IDApICkKICAgICAgICAgcmV0dXJuOwogCi0gICAgc2hhZG93X2RpcmVjdF9tYXBfaW5p dChkKTsKKyAgICBpZiAoIHNoYWRvd19kaXJlY3RfbWFwX2luaXQoZCkgPT0gMCApCisgICAgewor ICAgICAgICBwcmludGsoIkNhbiBub3QgYWxsb2NhdGUgc2hhZG93IGRpcmVjdCBtYXAgZm9yIEhW TSBkb21haW4uXG4iKTsKKyAgICAgICAgZG9tYWluX2NyYXNoX3N5bmNocm9ub3VzKCk7CisgICAg fQogCiAgICAgaHZtX21hcF9pb19zaGFyZWRfcGFnZShkKTsKICAgICBodm1fZ2V0X2luZm8oZCk7 CmRpZmYgLXJ1IGEveGVuL2FyY2gveDg2L2h2bS9zdm0vc3ZtLmMgeGVuLXVuc3RhYmxlLmhnL3hl bi9hcmNoL3g4Ni9odm0vc3ZtL3N2bS5jCi0tLSBhL3hlbi9hcmNoL3g4Ni9odm0vc3ZtL3N2bS5j CTIwMDYtMDUtMTggMTI6MTg6MzQuMDAwMDAwMDAwIC0wNjAwCisrKyB4ZW4tdW5zdGFibGUuaGcv eGVuL2FyY2gveDg2L2h2bS9zdm0vc3ZtLmMJMjAwNi0wNS0xOCAxMjozNjowNS4wMDAwMDAwMDAg LTA2MDAKQEAgLTQ1OCw2ICs0NTgsOSBAQAogICAgIAogICAgIGlmICghKHRlc3RfYml0KFg4Nl9G RUFUVVJFX1NWTUUsICZib290X2NwdV9kYXRhLng4Nl9jYXBhYmlsaXR5KSkpCiAgICAgICAgIHJl dHVybiAwOworICAgIHN2bV9nbG9iYWxzW2NwdV0uaHNhID0gYWxsb2NfaG9zdF9zYXZlX2FyZWEo KTsKKyAgICBpZiAoISBzdm1fZ2xvYmFsc1tjcHVdLmhzYSkKKyAgICAgICAgcmV0dXJuIDA7CiAg ICAgCiAgICAgcmRtc3IoTVNSX0VGRVIsIGVheCwgZWR4KTsKICAgICBlYXggfD0gRUZFUl9TVk1F OwpAQCAtNDY2LDcgKzQ2OSw2IEBACiAgICAgcHJpbnRrKCJBTUQgU1ZNIEV4dGVuc2lvbiBpcyBl bmFibGVkIGZvciBjcHUgJWQuXG4iLCBjcHUgKTsKIAogICAgIC8qIEluaXRpYWxpemUgdGhlIEhT QSBmb3IgdGhpcyBjb3JlICovCi0gICAgc3ZtX2dsb2JhbHNbY3B1XS5oc2EgPSBhbGxvY19ob3N0 X3NhdmVfYXJlYSgpOwogICAgIHBoeXNfaHNhID0gKHU2NCkgdmlydF90b19tYWRkciggc3ZtX2ds b2JhbHNbY3B1XS5oc2EgKTsgCiAgICAgcGh5c19oc2FfbG8gPSAodTMyKSBwaHlzX2hzYTsKICAg ICBwaHlzX2hzYV9oaSA9ICh1MzIpIChwaHlzX2hzYSA+PiAzMik7ICAgIApkaWZmIC1ydSBhL3hl bi9hcmNoL3g4Ni9odm0vc3ZtL3ZtY2IuYyB4ZW4tdW5zdGFibGUuaGcveGVuL2FyY2gveDg2L2h2 bS9zdm0vdm1jYi5jCi0tLSBhL3hlbi9hcmNoL3g4Ni9odm0vc3ZtL3ZtY2IuYwkyMDA2LTA1LTE4 IDEyOjE4OjM0LjAwMDAwMDAwMCAtMDYwMAorKysgeGVuLXVuc3RhYmxlLmhnL3hlbi9hcmNoL3g4 Ni9odm0vc3ZtL3ZtY2IuYwkyMDA2LTA1LTE4IDEyOjI0OjIxLjAwMDAwMDAwMCAtMDYwMApAQCAt MTM5LDE4ICsxMzksMjEgQEAKIAogICAgIC8qIFRoZSBmb2xsb3dpbmcgaXMgZm9yIEkvTyBhbmQg TVNSIHBlcm1pc2lvbiBtYXAgKi8KICAgICBpb3BtID0gYWxsb2NfeGVuaGVhcF9wYWdlcyhnZXRf b3JkZXJfZnJvbV9ieXRlcyhJT1BNX1NJWkUpKTsKLQotICAgIEFTU0VSVChpb3BtKTsKLSAgICBt ZW1zZXQoaW9wbSwgMHhmZiwgSU9QTV9TSVpFKTsKLSAgICBjbGVhcl9iaXQoUENfREVCVUdfUE9S VCwgaW9wbSk7CisgICAgaWYgKGlvcG0pCisgICAgeworICAgICAgICBtZW1zZXQoaW9wbSwgMHhm ZiwgSU9QTV9TSVpFKTsKKyAgICAgICAgY2xlYXJfYml0KFBDX0RFQlVHX1BPUlQsIGlvcG0pOwor ICAgIH0KICAgICBtc3JwbSA9IGFsbG9jX3hlbmhlYXBfcGFnZXMoZ2V0X29yZGVyX2Zyb21fYnl0 ZXMoTVNSUE1fU0laRSkpOwotCi0gICAgQVNTRVJUKG1zcnBtKTsKLSAgICBtZW1zZXQobXNycG0s IDB4ZmYsIE1TUlBNX1NJWkUpOworICAgIGlmIChtc3JwbSkKKyAgICAgICAgbWVtc2V0KG1zcnBt LCAweGZmLCBNU1JQTV9TSVpFKTsKIAogICAgIGFyY2hfc3ZtLT5pb3BtID0gaW9wbTsKICAgICBh cmNoX3N2bS0+bXNycG0gPSBtc3JwbTsKIAorICAgIGlmICghIGlvcG0gfHwgISBtc3JwbSkKKyAg ICAgICAgcmV0dXJuIDE7CisKICAgICB2bWNiLT5pb3BtX2Jhc2VfcGEgPSAodTY0KSB2aXJ0X3Rv X21hZGRyKGlvcG0pOwogICAgIHZtY2ItPm1zcnBtX2Jhc2VfcGEgPSAodTY0KSB2aXJ0X3RvX21h ZGRyKG1zcnBtKTsKIAo= --=__PartB3969633.0__= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --=__PartB3969633.0__=--