From: Zachary Amsden Subject: Re: [RFC PATCH 17/35] Segment register changes for Xen Date: Thu, 18 May 2006 13:20:15 -0700 Message-ID: <446CD6FF.30409@vmware.com> References: <20060509084945.373541000@sous-sol.org> <20060509085154.802230000@sous-sol.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20060509085154.802230000@sous-sol.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Chris Wright Cc: virtualization@lists.osdl.org, Christian Limpach , xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org, Ian Pratt List-Id: xen-devel@lists.xenproject.org Chris Wright wrote: > 1. We clear FS/GS before changing TLS entries and switching LDT, as > otherwise the hypervisor will fail to restore thread-local values on > return to the guest kernel and we take a slow exception path. > @@ -647,6 +647,8 @@ struct task_struct fastcall * __switch_t > */ > savesegment(fs, prev->fs); > savesegment(gs, prev->gs); > + clearsegment(fs); > + clearsegment(gs); > Really not needed. Think about it. You can even speed up Xen. I'm glad the native operation here is a nop, but it should be hypervisor_clearsegment or xen_clearsegment if you really want to keep it. Zach