From: "Ky Srinivasan" Subject: [PATCH]: Fixing the xchg emulation bug Date: Fri, 26 May 2006 15:44:58 -0600 Message-ID: <44773E9A.E57C.0030.0@novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=__PartE7C2D9CA.0__=" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org --=__PartE7C2D9CA.0__= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline The following patch fixes a bug in the emulation of the xchg instruction. This bug has prevented us from booting fully virtualized SMP guests that write to the APIC using the xchg instruction (when CONFIG_X86_GOOD_APIC is not set). On 32 bit platforms, sles 10 kernels are built without CONFIG_x86_GOOD_APIC not set and hence we have had problems booting fully virtualized SMP sles 10 guests. Signed- off- by K. Y. Srinivasan --=__PartE7C2D9CA.0__= Content-Type: application/octet-stream; name="hvm-xchg.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="hvm-xchg.diff" ZGlmZiAtTnVyIHhlbi9hcmNoL3g4Ni9odm0vaW8uYyB4ZW4tbmV3L2FyY2gveDg2L2h2bS9pby5j Ci0tLSB4ZW4vYXJjaC94ODYvaHZtL2lvLmMJMjAwNi0wNS0yNCAyMjo0MToyOC4wMDAwMDAwMDAg LTA0MDAKKysrIHhlbi1uZXcvYXJjaC94ODYvaHZtL2lvLmMJMjAwNi0wNS0yNiAwNjozODoxNy4w MDAwMDAwMDAgLTA0MDAKQEAgLTY0Niw2ICs2NDYsMTYgQEAKICAgICAgICAgICAgIHJlZ3MtPmVm bGFncyAmPSB+WDg2X0VGTEFHU19DRjsKIAogICAgICAgICBicmVhazsKKworICAgIGNhc2UgSU5T VFJfWENIRzoKKwlpZiAoc3JjICYgUkVHSVNURVIpIHsKKwkJaW5kZXggPSBvcGVyYW5kX2luZGV4 KHNyYyk7CisJCXNldF9yZWdfdmFsdWUoc2l6ZSwgaW5kZXgsIDAsIHJlZ3MsIHAtPnUuZGF0YSk7 CisJfSBlbHNlIHsKKwkJaW5kZXggPSBvcGVyYW5kX2luZGV4KGRzdCk7CisJCXNldF9yZWdfdmFs dWUoc2l6ZSwgaW5kZXgsIDAsIHJlZ3MsIHAtPnUuZGF0YSk7CisJfQorCWJyZWFrOwogICAgIH0K IAogICAgIGh2bV9sb2FkX2NwdV9ndWVzdF9yZWdzKHYsIHJlZ3MpOwpkaWZmIC1OdXIgeGVuL2Fy Y2gveDg2L2h2bS9wbGF0Zm9ybS5jIHhlbi1uZXcvYXJjaC94ODYvaHZtL3BsYXRmb3JtLmMKLS0t IHhlbi9hcmNoL3g4Ni9odm0vcGxhdGZvcm0uYwkyMDA2LTA1LTI0IDIyOjQxOjI4LjAwMDAwMDAw MCAtMDQwMAorKysgeGVuLW5ldy9hcmNoL3g4Ni9odm0vcGxhdGZvcm0uYwkyMDA2LTA1LTI2IDA2 OjI2OjU1LjAwMDAwMDAwMCAtMDQwMApAQCAtOTU0LDEwICs5NTQsMjYgQEAKICAgICAgICAgbW1p b19vcHAtPmluc3RyID0gbW1pb19pbnN0Lmluc3RyOwogICAgICAgICBtbWlvX29wcC0+b3BlcmFu ZFswXSA9IG1taW9faW5zdC5vcGVyYW5kWzBdOyAvKiBzb3VyY2UgKi8KICAgICAgICAgbW1pb19v cHAtPm9wZXJhbmRbMV0gPSBtbWlvX2luc3Qub3BlcmFuZFsxXTsgLyogZGVzdGluYXRpb24gKi8K LQotICAgICAgICAvKiBzZW5kIHRoZSByZXF1ZXN0IGFuZCB3YWl0IGZvciB0aGUgdmFsdWUgKi8K LSAgICAgICAgc2VuZF9tbWlvX3JlcShJT1JFUV9UWVBFX1hDSEcsIGdwYSwgMSwKLSAgICAgICAg ICAgICAgICAgICAgICBtbWlvX2luc3Qub3Bfc2l6ZSwgMCwgSU9SRVFfV1JJVEUsIDApOworCWlm IChtbWlvX2luc3Qub3BlcmFuZFswXSAmIFJFR0lTVEVSKSB7CisJCWxvbmcgdmFsdWU7CisJCXVu c2lnbmVkIGxvbmcgb3BlcmFuZCA9IG1taW9faW5zdC5vcGVyYW5kWzBdOworCQl2YWx1ZSA9IGdl dF9yZWdfdmFsdWUob3BlcmFuZF9zaXplKG9wZXJhbmQpLCAKKwkJCQkgICAgICBvcGVyYW5kX2lu ZGV4KG9wZXJhbmQpLCAwLAorICAgICAgICAgICAgICAgICAgICAJCSAgICAgIG1taW9fb3BwLT5p bnN0X2RlY29kZXJfcmVncyk7CisgICAgICAgIAkvKiBzZW5kIHRoZSByZXF1ZXN0IGFuZCB3YWl0 IGZvciB0aGUgdmFsdWUgKi8KKyAgICAgICAgCXNlbmRfbW1pb19yZXEoSU9SRVFfVFlQRV9YQ0hH LCBncGEsIDEsCisgICAgICAgICAgICAgICAgICAgICAgbW1pb19pbnN0Lm9wX3NpemUsIHZhbHVl LCBJT1JFUV9XUklURSwgMCk7CisJfSBlbHNlIHsKKwkJLyogdGhlIGRlc3RpbmF0aW9uIGlzIGEg cmVnaXN0ZXIgKi8KKwkJbG9uZyB2YWx1ZTsKKwkJdW5zaWduZWQgbG9uZyBvcGVyYW5kID0gbW1p b19pbnN0Lm9wZXJhbmRbMV07CisJCXZhbHVlID0gZ2V0X3JlZ192YWx1ZShvcGVyYW5kX3NpemUo b3BlcmFuZCksIAorCQkJCSAgICAgIG9wZXJhbmRfaW5kZXgob3BlcmFuZCksIDAsCisgICAgICAg ICAgICAgICAgICAgIAkJICAgICAgbW1pb19vcHAtPmluc3RfZGVjb2Rlcl9yZWdzKTsKKyAgICAg ICAgCS8qIHNlbmQgdGhlIHJlcXVlc3QgYW5kIHdhaXQgZm9yIHRoZSB2YWx1ZSAqLworICAgICAg ICAJc2VuZF9tbWlvX3JlcShJT1JFUV9UWVBFX1hDSEcsIGdwYSwgMSwKKyAgICAgICAgICAgICAg ICAgICAgICBtbWlvX2luc3Qub3Bfc2l6ZSwgdmFsdWUsIElPUkVRX1dSSVRFLCAwKTsKKwl9CiAg ICAgICAgIGJyZWFrOwogCiAgICAgZGVmYXVsdDoK --=__PartE7C2D9CA.0__= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --=__PartE7C2D9CA.0__=--