Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DFEAC5479D for ; Mon, 9 Jan 2023 19:35:12 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0738E817FB; Mon, 9 Jan 2023 20:35:10 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1673292910; bh=C0fOl1RCoU0gOMJYD2N4AVLRCONgIq5X4IQ6mfC7Q1k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=wdu1PMuoThU+hwYAQWjReb01DsgpkFwbokPStF6c7RRdIsWTpmxmiWAY7Vqk7lT4e hpMPnaskcc0heRPevi4w3ccvGC1YjejrJtdJH+nBY1FjTDaKNlzLseKgK/WobyiRTW dmErIXSD0btSDzy615r4NGBXgZH3rliJtq6Ekemm6YJa23awbOXvihMnAMfmxaP4Ht G8kP/4v6rLZIN5PstWobdQmB7spFi4+iuaPYESpYcw1Aoey7uUqb1T9ZAuqfEtM+Hz jk2x4Qw4xBmxI//LKrxJ+uFTj/Gk2Xo4iXLLeC1Tzi8F4TM2wthyGCOc1aw94k9aNx BNjzjIP5UjVow== Received: from mail.denx.de (unknown [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: festevam@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id DF2D182131; Mon, 9 Jan 2023 20:35:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1673292907; bh=C0fOl1RCoU0gOMJYD2N4AVLRCONgIq5X4IQ6mfC7Q1k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dqWasr7szUjbVFalwjTQCPWfywVm/Ni8umUS+5zYmFB+4Yb1QK34CcmiMGU6NGL8X ZwaDJ4FfkXn+1YdgkU4IvgOr5hzVU1uWA4NFkoD3ns6iJp5NCDV90Lvx1a8GZHGTY+ AoDgpau2DKI7LTxafrRjNSP/GZzb1MkJop7pyklsc47yysf6FrBXW9vdjPuDyFBMfh DxfUkOuvp5hHtb1FZ6H40pzYKQdjIeMlD3JnBtNRBGkZ6mhf4bmyhQL3ZCWK1R5TTa qsK2Ed3mC/bd7i7UIQGofKtdGvLf19+l5FRCsNATynSzv4UTGdWNOluscmyQdUN5Ey WdWXXEDB1cfWQ== MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 09 Jan 2023 16:35:07 -0300 From: Fabio Estevam To: Tom Rini Cc: sbabic@denx.de, u-boot@lists.denx.de Subject: Re: [PATCH] imx8mm-phg: Add board support In-Reply-To: <20230109190005.GD3787616@bill-the-cat> References: <20230109175955.1007160-1-festevam@denx.de> <20230109190005.GD3787616@bill-the-cat> Message-ID: <44817526eb70304eeb1f1d9c227e0cf1@denx.de> X-Sender: festevam@denx.de User-Agent: Roundcube Webmail/1.3.6 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Tom, On 09/01/2023 16:00, Tom Rini wrote: > This is going to need to be rebased on top of current master due to > CONFIG -> CFG or Kconfig migration. On top of that: Ok, I will rebase on top of the current master. >> +#define CONFIG_SYS_SDRAM_BASE 0x40000000 >> +#define PHYS_SDRAM 0x40000000 >> +#define PHYS_SDRAM_SIZE 0x80000000 /* 2GB DDR */ > > Please make sure we need to define PHYS_SDRAM* at all. Thanks! Sorry, I don't understand this comment. PHYS_SDRAM and PHYS_SDRAM_SIZE are used by arch/arm/mach-imx/imx8m/soc.c. Regards, Fabio Estevam -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-60 Fax: (+49)-8142-66989-80 Email: festevam@denx.de