From: "Charles Coffing" Subject: [PATCH] gracefully handle alloc failure in sched_credit.c Date: Tue, 01 Aug 2006 13:08:59 -0400 Message-ID: <44CF361A.D169.003C.0@novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=__PartD2F754BB.0__=" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org --=__PartD2F754BB.0__= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline There is an allocation-failure path in sched_credit.c that BUGs. The attached patch handles this potential failure case more gracefully. Signed-off-by: Charles Coffing --=__PartD2F754BB.0__= Content-Type: application/octet-stream; name="xen-sched-credit-bugon.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="xen-sched-credit-bugon.diff" LS0tIHhlbi11bnN0YWJsZS94ZW4vY29tbW9uL3NjaGVkX2NyZWRpdC5jCTIwMDYtMDYtMzAgMTU6 MDI6MzYuMDAwMDAwMDAwIC0wNjAwCisrKyB4ZW4tdW5zdGFibGUuYi94ZW4vY29tbW9uL3NjaGVk X2NyZWRpdC5jCTIwMDYtMDgtMDEgMTA6NTQ6MjcuMDAwMDAwMDAwIC0wNjAwCkBAIC0yOTYsMTIg KzI5NiwxNyBAQAogICAgICAgICBjcHVtYXNrX3JhaXNlX3NvZnRpcnEobWFzaywgU0NIRURVTEVf U09GVElSUSk7CiB9CiAKLXN0YXRpYyB2b2lkCitzdGF0aWMgaW50CiBjc2NoZWRfcGNwdV9pbml0 KGludCBjcHUpCiB7CiAgICAgc3RydWN0IGNzY2hlZF9wY3B1ICpzcGM7CiAgICAgdW5zaWduZWQg bG9uZyBmbGFnczsKIAorICAgIC8qIEFsbG9jYXRlIHBlci1QQ1BVIGluZm8gKi8KKyAgICBzcGMg PSB4bWFsbG9jKHN0cnVjdCBjc2NoZWRfcGNwdSk7CisgICAgaWYgKCBzcGMgPT0gTlVMTCApCisg ICAgICAgIHJldHVybiAtMTsKKwogICAgIHNwaW5fbG9ja19pcnFzYXZlKCZjc2NoZWRfcHJpdi5s b2NrLCBmbGFncyk7CiAKICAgICAvKiBJbml0aWFsaXplL3VwZGF0ZSBzeXN0ZW0td2lkZSBjb25m aWcgKi8KQEAgLTMxMSw5ICszMTYsNiBAQAogICAgIGlmICggY3NjaGVkX3ByaXYubWFzdGVyID49 IGNzY2hlZF9wcml2Lm5jcHVzICkKICAgICAgICAgY3NjaGVkX3ByaXYubWFzdGVyID0gY3B1Owog Ci0gICAgLyogQWxsb2NhdGUgcGVyLVBDUFUgaW5mbyAqLwotICAgIHNwYyA9IHhtYWxsb2Moc3Ry dWN0IGNzY2hlZF9wY3B1KTsKLSAgICBCVUdfT04oIHNwYyA9PSBOVUxMICk7CiAgICAgSU5JVF9M SVNUX0hFQUQoJnNwYy0+cnVucSk7CiAgICAgc3BjLT5ydW5xX3NvcnRfbGFzdCA9IGNzY2hlZF9w cml2LnJ1bnFfc29ydDsKICAgICBzY2hlZHVsZV9kYXRhW2NwdV0uc2NoZWRfcHJpdiA9IHNwYzsK QEAgLTMyMyw2ICszMjUsOCBAQAogICAgIGNwdV9zZXQoY3B1LCBjc2NoZWRfcHJpdi5pZGxlcnMp OwogCiAgICAgc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmY3NjaGVkX3ByaXYubG9jaywgZmxhZ3Mp OworCisgICAgcmV0dXJuIDA7CiB9CiAKICNpZm5kZWYgTkRFQlVHCkBAIC00OTAsNyArNDk0LDEw IEBACiAKICAgICAvKiBBbGxvY2F0ZSBwZXItUENQVSBpbmZvICovCiAgICAgaWYgKCB1bmxpa2Vs eSghQ1NDSEVEX1BDUFUodmMtPnByb2Nlc3NvcikpICkKLSAgICAgICAgY3NjaGVkX3BjcHVfaW5p dCh2Yy0+cHJvY2Vzc29yKTsKKyAgICB7CisgICAgICAgIGlmICggY3NjaGVkX3BjcHVfaW5pdCh2 Yy0+cHJvY2Vzc29yKSAhPSAwKQorICAgICAgICAgICAgcmV0dXJuIC0xOworICAgIH0KIAogICAg IENTQ0hFRF9WQ1BVX0NIRUNLKHZjKTsKIAo= --=__PartD2F754BB.0__= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --=__PartD2F754BB.0__=--