From: "Jan Beulich" <jbeulich@novell.com>
Subject: Re: [PATCH] linux: don't bring up CPUs that can
	never be used
Date: Mon, 14 Aug 2006 15:23:50 +0200
Message-ID: <44E09586.76E4.0078.0@novell.com>
References: <44E0904E.76E4.0078.0@novell.com>
	<C1063627.D4F%Keir.Fraser@cl.cam.ac.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C1063627.D4F%Keir.Fraser@cl.cam.ac.uk>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

>> Without this, "nosmp" or "max_cpus=" Linux command line options are
>> being ignored.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@novell.com>
>
>I'm a little bit wary of the second hunk. Although it's probably okay,
is it
>actually required? Looks like the first hunk is what fixes the issue.

It's probably not strictly required, but sill better than iterating
over NR_CPUS, as
that is what mainline is in the process of phasing out. The only
difference I can
see to the results of the original code is that for cpu 0 the two array
members
now also get (re-)initialized here - but the value stored should be the
same as
may have been stored earlier.

Jan