From: "Charles Coffing" Subject: [RFC][PATCH] auto-starting viewer for virtual frame buffer Date: Fri, 01 Sep 2006 15:17:17 -0400 Message-ID: <44F8327F.D169.003C.0@novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=__Part7E5BCF2D.0__=" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com, Markus Armbruster, armbru@redhat.com List-Id: xen-devel@lists.xenproject.org --=__Part7E5BCF2D.0__= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Content-Disposition: inline It seems that discussion of the virtual frame buffer has died down; I = assume this is being held off until after 3.0.3 splits... Nevertheless, I was playing with it and wanted to put this patch out for = discussion. This patch is a rough attempt to make the SDL/VNC viewers = behave similarly for both paravirtual and fully virtual domains. For = example, if you specify "sdl=3D1" in a paravirtual config file, "xm = create" will cause sdlfb to start automatically. My desire is to make para vs. full not appear so different to the casual = user. Config file syntax should be similar, viewers should start in = similar ways, etc. If others agree, then there's certainly more to do. (Killing the VM = should close the viewer and vice versa; the vncviewer setting is not yet = hooked up; viewer paths are hard coded; etc...) But I wanted to put the = idea out there to see if others agree with this direction. Thanks, Charles --=__Part7E5BCF2D.0__= Content-Type: application/octet-stream; name="vfb-viewer.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="vfb-viewer.diff" SW5kZXg6IHhlbi11bnN0YWJsZS90b29scy9weXRob24veGVuL3hlbmQvWGVuZERvbWFpbkluZm8u cHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0geGVuLXVuc3RhYmxlLm9yaWcvdG9vbHMvcHl0aG9uL3hlbi94ZW5k L1hlbmREb21haW5JbmZvLnB5CisrKyB4ZW4tdW5zdGFibGUvdG9vbHMvcHl0aG9uL3hlbi94ZW5k L1hlbmREb21haW5JbmZvLnB5CkBAIC0xNDgxLDcgKzE0ODEsNyBAQCBjbGFzcyBYZW5kRG9tYWlu SW5mbzoKICAgICAgICAgICAgIHNlbGYuY3JlYXRlRGV2aWNlKG4sIGMpCiAKICAgICAgICAgaWYg c2VsZi5pbWFnZToKLSAgICAgICAgICAgIHNlbGYuaW1hZ2UuY3JlYXRlRGV2aWNlTW9kZWwoKQor ICAgICAgICAgICAgc2VsZi5pbWFnZS5zcGF3bkhlbHBlcigpCiAKICAgICAjIyBwdWJsaWM6CiAK SW5kZXg6IHhlbi11bnN0YWJsZS90b29scy9weXRob24veGVuL3hlbmQvaW1hZ2UucHkKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0geGVuLXVuc3RhYmxlLm9yaWcvdG9vbHMvcHl0aG9uL3hlbi94ZW5kL2ltYWdlLnB5 CisrKyB4ZW4tdW5zdGFibGUvdG9vbHMvcHl0aG9uL3hlbi94ZW5kL2ltYWdlLnB5CkBAIC01NSw4 ICs1NSw4IEBAIGNsYXNzIEltYWdlSGFuZGxlcjoKICAgICBkZWZpbmVkIGluIGEgc3ViY2xhc3Mu ICBVc3VhbGx5IHRoaXMgaXMgdGhlIG9ubHkgbWV0aG9kIHRoYXQgbmVlZHMKICAgICBkZWZpbmlu ZyBpbiBhIHN1YmNsYXNzLgogCi0gICAgVGhlIG1ldGhvZCBjcmVhdGVEZXZpY2VNb2RlbCgpIGlz IGNhbGxlZCB0byBjcmVhdGUgdGhlIGRvbWFpbiBkZXZpY2UKLSAgICBtb2RlbCBpZiBpdCBuZWVk cyBvbmUuICBUaGUgZGVmYXVsdCBpcyB0byBkbyBub3RoaW5nLgorICAgIFRoZSBtZXRob2Qgc3Bh d25IZWxwZXIoKSBpcyBjYWxsZWQgdG8gY3JlYXRlIGFueSBhc3Npc3RpbmcgcHJvY2Vzc2VzLAor ICAgIHN1Y2ggYXMgdGhlIGRvbWFpbiBkZXZpY2UgbW9kZWwuICBUaGUgZGVmYXVsdCBpcyB0byBk byBub3RoaW5nLgogCiAgICAgVGhlIG1ldGhvZCBkZXN0cm95KCkgaXMgY2FsbGVkIHdoZW4gdGhl IGRvbWFpbiBpcyBkZXN0cm95ZWQuCiAgICAgVGhlIGRlZmF1bHQgaXMgdG8gZG8gbm90aGluZy4K QEAgLTcxLDYgKzcxLDkgQEAgY2xhc3MgSW1hZ2VIYW5kbGVyOgogICAgICAgICBzZWxmLmtlcm5l bCA9IE5vbmUKICAgICAgICAgc2VsZi5yYW1kaXNrID0gTm9uZQogICAgICAgICBzZWxmLmNtZGxp bmUgPSBOb25lCisgICAgICAgIHNlbGYuaGVscGVyID0gTm9uZQorICAgICAgICBzZWxmLmhlbHBl cl9hcmdzID0gW10KKyAgICAgICAgc2VsZi5waWQgPSAwCiAKICAgICAgICAgc2VsZi5jb25maWd1 cmUoaW1hZ2VDb25maWcsIGRldmljZUNvbmZpZykKIApAQCAtOTMsMTAgKzk2LDE0IEBAIGNsYXNz IEltYWdlSGFuZGxlcjoKICAgICAgICAgICAgIHNlbGYuY21kbGluZSArPSAiICIgKyBhcmdzCiAg ICAgICAgIHNlbGYucmFtZGlzayA9IGdldF9jZmcoInJhbWRpc2siLCAnJykKICAgICAgICAgCisg ICAgICAgIHNlbGYuZGlzcGxheSA9IHN4cC5jaGlsZF92YWx1ZShpbWFnZUNvbmZpZywgJ2Rpc3Bs YXknKQorICAgICAgICBzZWxmLnhhdXRob3JpdHkgPSBzeHAuY2hpbGRfdmFsdWUoaW1hZ2VDb25m aWcsICd4YXV0aG9yaXR5JykKKwogICAgICAgICBzZWxmLnZtLnN0b3JlVm0oKCJpbWFnZS9vc3R5 cGUiLCBzZWxmLm9zdHlwZSksCiAgICAgICAgICAgICAgICAgICAgICAgICAoImltYWdlL2tlcm5l bCIsIHNlbGYua2VybmVsKSwKICAgICAgICAgICAgICAgICAgICAgICAgICgiaW1hZ2UvY21kbGlu ZSIsIHNlbGYuY21kbGluZSksCi0gICAgICAgICAgICAgICAgICAgICAgICAoImltYWdlL3JhbWRp c2siLCBzZWxmLnJhbWRpc2spKQorICAgICAgICAgICAgICAgICAgICAgICAgKCJpbWFnZS9yYW1k aXNrIiwgc2VsZi5yYW1kaXNrKSwKKyAgICAgICAgICAgICAgICAgICAgICAgICgiaW1hZ2UvZGlz cGxheSIsIHNlbGYuZGlzcGxheSkpCiAKIAogICAgIGRlZiBjbGVhbnVwQm9vdGxvYWRpbmcoc2Vs Zik6CkBAIC0xNTYsOSArMTYzLDIyIEBAIGNsYXNzIEltYWdlSGFuZGxlcjoKICAgICAgICAgIiIi QnVpbGQgdGhlIGRvbWFpbi4gRGVmaW5lIGluIHN1YmNsYXNzLiIiIgogICAgICAgICByYWlzZSBO b3RJbXBsZW1lbnRlZEVycm9yKCkKIAotICAgIGRlZiBjcmVhdGVEZXZpY2VNb2RlbChzZWxmKToK LSAgICAgICAgIiIiQ3JlYXRlIGRldmljZSBtb2RlbCBmb3IgdGhlIGRvbWFpbiAoZGVmaW5lIGlu IHN1YmNsYXNzIGlmIG5lZWRlZCkuIiIiCi0gICAgICAgIHBhc3MKKyAgICBkZWYgc3Bhd25IZWxw ZXIoc2VsZik6CisgICAgICAgICIiIkNyZWF0ZSB0aGUgaGVscGVyIHByb2Nlc3MgZm9yIHRoZSBk b21haW4uIiIiCisgICAgICAgIGlmIHNlbGYucGlkOgorICAgICAgICAgICAgcmV0dXJuCisgICAg ICAgIGlmIG5vdCBzZWxmLmhlbHBlcjoKKyAgICAgICAgICAgIHJldHVybgorICAgICAgICBhcmdz ID0gW3NlbGYuaGVscGVyXQorICAgICAgICBhcmdzICs9IHNlbGYuaGVscGVyX2FyZ3MKKyAgICAg ICAgZW52ID0gZGljdChvcy5lbnZpcm9uKQorICAgICAgICBpZiBzZWxmLmRpc3BsYXk6CisgICAg ICAgICAgICBlbnZbJ0RJU1BMQVknXSA9IHNlbGYuZGlzcGxheQorICAgICAgICBpZiBzZWxmLnhh dXRob3JpdHk6CisgICAgICAgICAgICBlbnZbJ1hBVVRIT1JJVFknXSA9IHNlbGYueGF1dGhvcml0 eQorICAgICAgICBsb2cuaW5mbygic3Bhd25pbmcgaGVscGVyOiAlcyAlcyIsIHNlbGYuaGVscGVy LCBhcmdzKQorICAgICAgICBzZWxmLnBpZCA9IG9zLnNwYXdudmUob3MuUF9OT1dBSVQsIHNlbGYu aGVscGVyLCBhcmdzLCBlbnYpCisgICAgICAgIGxvZy5pbmZvKCJoZWxwZXIgcGlkOiAlZCIsIHNl bGYucGlkKQogICAgIAogICAgIGRlZiBkZXN0cm95KHNlbGYpOgogICAgICAgICAiIiJFeHRyYSBj bGVhbnVwIG9uIGRvbWFpbiBkZXN0cm95IChkZWZpbmUgaW4gc3ViY2xhc3MgaWYgbmVlZGVkKS4i IiIKQEAgLTE2OSw2ICsxODksMjUgQEAgY2xhc3MgTGludXhJbWFnZUhhbmRsZXIoSW1hZ2VIYW5k bGVyKToKIAogICAgIG9zdHlwZSA9ICJsaW51eCIKIAorICAgIGRlZiBzcGF3bkhlbHBlcihzZWxm KToKKyAgICAgICAgaWYgc2VsZi5waWQ6CisgICAgICAgICAgICByZXR1cm4KKyAgICAgICAgaWYg bm90IHNlbGYuaGVscGVyOgorICAgICAgICAgICAgcmV0dXJuCisgICAgICAgIHNlbGYuaGVscGVy X2FyZ3MgPSBbIHN0cihzZWxmLnZtLmdldERvbWlkKCkpIF0KKyAgICAgICAgSW1hZ2VIYW5kbGVy LnNwYXduSGVscGVyKHNlbGYpCisKKyAgICBkZWYgY29uZmlndXJlKHNlbGYsIGltYWdlQ29uZmln LCBkZXZpY2VDb25maWcpOgorICAgICAgICBJbWFnZUhhbmRsZXIuY29uZmlndXJlKHNlbGYsIGlt YWdlQ29uZmlnLCBkZXZpY2VDb25maWcpCisgICAgICAgIHNkbCA9IHN4cC5jaGlsZF92YWx1ZShp bWFnZUNvbmZpZywgJ3NkbCcpCisgICAgICAgIHZuYyA9IHN4cC5jaGlsZF92YWx1ZShpbWFnZUNv bmZpZywgJ3ZuYycpCisgICAgICAgIGlmIHNkbDoKKyAgICAgICAgICAgIHNlbGYuaGVscGVyID0g Ii91c3IvbGliL3hlbi9iaW4vc2RsZmIiCisgICAgICAgIGVsaWYgdm5jOgorICAgICAgICAgICAg c2VsZi5oZWxwZXIgPSAiL3Vzci9saWIveGVuL2Jpbi92bmNmYiIKKyAgICAgICAgZWxzZToKKyAg ICAgICAgICAgIHNlbGYuaGVscGVyID0gTm9uZQorCiAgICAgZGVmIGJ1aWxkRG9tYWluKHNlbGYp OgogICAgICAgICBzdG9yZV9ldnRjaG4gPSBzZWxmLnZtLmdldFN0b3JlUG9ydCgpCiAgICAgICAg IGNvbnNvbGVfZXZ0Y2huID0gc2VsZi52bS5nZXRDb25zb2xlUG9ydCgpCkBAIC0yMzIsMTggKzI3 MSwxMyBAQCBjbGFzcyBIVk1JbWFnZUhhbmRsZXIoSW1hZ2VIYW5kbGVyKToKICAgICAgICAgICAg IHJhaXNlIFZtRXJyb3IoIk5vdCBhbiBIVk0gY2FwYWJsZSBwbGF0Zm9ybSwgd2Ugc3RvcCBjcmVh dGluZyEiKQogCiAgICAgICAgIHNlbGYuZG1hcmdzID0gc2VsZi5wYXJzZURldmljZU1vZGVsQXJn cyhpbWFnZUNvbmZpZywgZGV2aWNlQ29uZmlnKQotICAgICAgICBzZWxmLmRldmljZV9tb2RlbCA9 IHN4cC5jaGlsZF92YWx1ZShpbWFnZUNvbmZpZywgJ2RldmljZV9tb2RlbCcpCi0gICAgICAgIGlm IG5vdCBzZWxmLmRldmljZV9tb2RlbDoKKyAgICAgICAgc2VsZi5oZWxwZXIgPSBzeHAuY2hpbGRf dmFsdWUoaW1hZ2VDb25maWcsICdkZXZpY2VfbW9kZWwnKQorICAgICAgICBpZiBub3Qgc2VsZi5o ZWxwZXI6CiAgICAgICAgICAgICByYWlzZSBWbUVycm9yKCJodm06IG1pc3NpbmcgZGV2aWNlIG1v ZGVsIikKLSAgICAgICAgc2VsZi5kaXNwbGF5ID0gc3hwLmNoaWxkX3ZhbHVlKGltYWdlQ29uZmln LCAnZGlzcGxheScpCi0gICAgICAgIHNlbGYueGF1dGhvcml0eSA9IHN4cC5jaGlsZF92YWx1ZShp bWFnZUNvbmZpZywgJ3hhdXRob3JpdHknKQogICAgICAgICBzZWxmLnZuY2NvbnNvbGUgPSBzeHAu Y2hpbGRfdmFsdWUoaW1hZ2VDb25maWcsICd2bmNjb25zb2xlJykKIAogICAgICAgICBzZWxmLnZt LnN0b3JlVm0oKCJpbWFnZS9kbWFyZ3MiLCAiICIuam9pbihzZWxmLmRtYXJncykpLAotICAgICAg ICAgICAgICAgICAgICAgICAgKCJpbWFnZS9kZXZpY2UtbW9kZWwiLCBzZWxmLmRldmljZV9tb2Rl bCksCi0gICAgICAgICAgICAgICAgICAgICAgICAoImltYWdlL2Rpc3BsYXkiLCBzZWxmLmRpc3Bs YXkpKQotCi0gICAgICAgIHNlbGYucGlkID0gMAorICAgICAgICAgICAgICAgICAgICAgICAgKCJp bWFnZS9kZXZpY2UtbW9kZWwiLCBzZWxmLmhlbHBlcikpCiAKICAgICAgICAgc2VsZi5kbWFyZ3Mg Kz0gc2VsZi5jb25maWdWTkMoaW1hZ2VDb25maWcpCiAKQEAgLTM0OSwyNSArMzgzLDE4IEBAIGNs YXNzIEhWTUltYWdlSGFuZGxlcihJbWFnZUhhbmRsZXIpOgogICAgICAgICAgICAgICAgIHJldCAr PSBbJy12bmN1bnVzZWQnXQogICAgICAgICByZXR1cm4gcmV0CiAKLSAgICBkZWYgY3JlYXRlRGV2 aWNlTW9kZWwoc2VsZik6CisgICAgZGVmIHNwYXduSGVscGVyKHNlbGYpOgogICAgICAgICBpZiBz ZWxmLnBpZDoKICAgICAgICAgICAgIHJldHVybgogICAgICAgICAjIEV4ZWN1dGUgZGV2aWNlIG1v ZGVsLgogICAgICAgICAjdG9kbzogRXJyb3IgaGFuZGxpbmcKLSAgICAgICAgYXJncyA9IFtzZWxm LmRldmljZV9tb2RlbF0KLSAgICAgICAgYXJncyA9IGFyZ3MgKyAoWyAiLWQiLCAgIiVkIiAlIHNl bGYudm0uZ2V0RG9taWQoKSwKKyAgICAgICAgYXJncyA9IChbICItZCIsICAiJWQiICUgc2VsZi52 bS5nZXREb21pZCgpLAogICAgICAgICAgICAgICAgICAgIi1tIiwgIiVzIiAlIChzZWxmLnZtLmdl dE1lbW9yeVRhcmdldCgpIC8gMTAyNCldKQogICAgICAgICBhcmdzID0gYXJncyArIHNlbGYuZG1h cmdzCi0gICAgICAgIGVudiA9IGRpY3Qob3MuZW52aXJvbikKLSAgICAgICAgaWYgc2VsZi5kaXNw bGF5OgotICAgICAgICAgICAgZW52WydESVNQTEFZJ10gPSBzZWxmLmRpc3BsYXkKLSAgICAgICAg aWYgc2VsZi54YXV0aG9yaXR5OgotICAgICAgICAgICAgZW52WydYQVVUSE9SSVRZJ10gPSBzZWxm LnhhdXRob3JpdHkKICAgICAgICAgaWYgc2VsZi52bmNjb25zb2xlOgogICAgICAgICAgICAgYXJn cyA9IGFyZ3MgKyAoWyAiLXZuY3ZpZXdlciIgXSkKLSAgICAgICAgbG9nLmluZm8oInNwYXduaW5n IGRldmljZSBtb2RlbHM6ICVzICVzIiwgc2VsZi5kZXZpY2VfbW9kZWwsIGFyZ3MpCi0gICAgICAg IHNlbGYucGlkID0gb3Muc3Bhd252ZShvcy5QX05PV0FJVCwgc2VsZi5kZXZpY2VfbW9kZWwsIGFy Z3MsIGVudikKLSAgICAgICAgbG9nLmluZm8oImRldmljZSBtb2RlbCBwaWQ6ICVkIiwgc2VsZi5w aWQpCisgICAgICAgIHNlbGYuaGVscGVyX2FyZ3MgPSBhcmdzCisgICAgICAgIEltYWdlSGFuZGxl ci5zcGF3bkhlbHBlcihzZWxmKQogCiAgICAgZGVmIGRlc3Ryb3koc2VsZik6CiAgICAgICAgIHNl bGYudW5yZWdpc3Rlcl9zaHV0ZG93bl93YXRjaCgpOwpJbmRleDogeGVuLXVuc3RhYmxlL3Rvb2xz L3B5dGhvbi94ZW4veG0vY3JlYXRlLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHhlbi11bnN0YWJsZS5vcmln L3Rvb2xzL3B5dGhvbi94ZW4veG0vY3JlYXRlLnB5CisrKyB4ZW4tdW5zdGFibGUvdG9vbHMvcHl0 aG9uL3hlbi94bS9jcmVhdGUucHkKQEAgLTQ4MSw2ICs0ODEsMTEgQEAgZGVmIGNvbmZpZ3VyZV9p bWFnZSh2YWxzKToKICAgICBpZiB2YWxzLmV4dHJhOgogICAgICAgICBjb25maWdfaW1hZ2UuYXBw ZW5kKFsnYXJncycsIHZhbHMuZXh0cmFdKQogCisgICAgYXJncyA9IFsgJ3ZuYycsICdzZGwnLCAn ZGlzcGxheScsICd4YXV0aG9yaXR5JyBdCisgICAgZm9yIGEgaW4gYXJnczoKKyAgICAgICAgaWYg KHZhbHMuX19kaWN0X19bYV0pOgorICAgICAgICAgICAgY29uZmlnX2ltYWdlLmFwcGVuZChbYSwg dmFscy5fX2RpY3RfX1thXV0pCisKICAgICBpZiB2YWxzLmJ1aWxkZXIgPT0gJ2h2bSc6CiAgICAg ICAgIGNvbmZpZ3VyZV9odm0oY29uZmlnX2ltYWdlLCB2YWxzKQogICAgICAgICAKQEAgLTYzNiw4 ICs2NDEsOCBAQCBkZWYgY29uZmlndXJlX2h2bShjb25maWdfaW1hZ2UsIHZhbHMpOgogICAgICIi IgogICAgIGFyZ3MgPSBbICdkZXZpY2VfbW9kZWwnLCAncGFlJywgJ3ZjcHVzJywgJ2Jvb3QnLCAn ZmRhJywgJ2ZkYicsCiAgICAgICAgICAgICAgJ2xvY2FsdGltZScsICdzZXJpYWwnLCAnc3Rkdmdh JywgJ2lzYScsICdub2dyYXBoaWMnLCAnc291bmRodycsCi0gICAgICAgICAgICAgJ3ZuYycsICd2 bmNkaXNwbGF5JywgJ3ZuY3VudXNlZCcsICd2bmNjb25zb2xlJywgJ3NkbCcsICdkaXNwbGF5JywK LSAgICAgICAgICAgICAnYWNwaScsICdhcGljJywgJ3hhdXRob3JpdHknLCAndXNiJywgJ3VzYmRl dmljZScgXQorICAgICAgICAgICAgICd2bmNkaXNwbGF5JywgJ3ZuY3VudXNlZCcsICd2bmNjb25z b2xlJywKKyAgICAgICAgICAgICAnYWNwaScsICdhcGljJywgJ3VzYicsICd1c2JkZXZpY2UnIF0K ICAgICBmb3IgYSBpbiBhcmdzOgogICAgICAgICBpZiAodmFscy5fX2RpY3RfX1thXSk6CiAgICAg ICAgICAgICBjb25maWdfaW1hZ2UuYXBwZW5kKFthLCB2YWxzLl9fZGljdF9fW2FdXSkK --=__Part7E5BCF2D.0__= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --=__Part7E5BCF2D.0__=--