From: Jeremy Fitzhardinge Subject: Re: [PATCH 08/22][RFC] Unionfs: Directory manipulation helper functions Date: Mon, 04 Sep 2006 00:23:14 -0700 Message-ID: <44FBD462.1040902@goop.org> References: <20060901013512.GA5788@fsl.cs.sunysb.edu> <20060901014708.GI5788@fsl.cs.sunysb.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Josef Sipek , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, hch@infradead.org, akpm@osdl.org, viro@ftp.linux.org.uk Return-path: Received: from gw.goop.org ([64.81.55.164]:60125 "EHLO mail.goop.org") by vger.kernel.org with ESMTP id S932440AbWIDHXN (ORCPT ); Mon, 4 Sep 2006 03:23:13 -0400 To: Jan Engelhardt In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Jan Engelhardt wrote: >> + if (0 <= bopaque && bopaque < bend) >> > > Turn it. Constant values are usually wanted on the right side. > > bopaque >= 0 Not in this case. The test in its current form clearly shows that bopaque needs to be within a range. J -- VGER BF report: H 0