From: Maarten Lankhorst Subject: Re: [Intel-gfx] [PATCH] drm/atomic-helper: Fix leak in disable_all Date: Wed, 19 Jul 2017 12:15:27 +0200 Message-ID: <44b548f7-8511-b377-db42-4974438449b4@linux.intel.com> References: <20170714224656.6431-1-daniel.vetter@ffwll.ch> <20170715093106.19873-1-daniel.vetter@ffwll.ch> <99354236-94a5-4e04-79b2-ce7593e69e0d@linux.intel.com> <20170717152134.xihj3b3bfpcxqctj@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170717152134.xihj3b3bfpcxqctj@phenom.ffwll.local> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , DRI Development , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T3AgMTctMDctMTcgb20gMTc6MjEgc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+IE9uIE1vbiwgSnVs IDE3LCAyMDE3IGF0IDExOjM5OjU2QU0gKzAyMDAsIE1hYXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+ PiBPcCAxNS0wNy0xNyBvbSAxMTozMSBzY2hyZWVmIERhbmllbCBWZXR0ZXI6Cj4+PiBUaGUgbGVn YWN5IHBsYW5lLT5mYiBwb2ludGVyIGlzIHJlZmNvdW50ZWQgYnkgY2FsbGluZwo+Pj4gZHJtX2F0 b21pY19jbGVhbl9vbGRfZmIoKS4KPj4+Cj4+PiBJbiBwcmFjdGljZSB0aGlzIGlzbid0IGEgcmVh bCBwcm9ibGVtIGJlY2F1c2U6Cj4+PiAtIFRoZSBjYWxsZXIgaW4gdGhlIGk5MTUgZ3B1IHJlc2V0 IGNvZGUgcmVzdG9yZXMgdGhlIG9yaWdpbmFsIHN0YXRlCj4+PiAgIGFnYWluLCB3aGljaCBtZWFu cyB0aGUgcGxhbmUtPmZiIHBvaW50ZXIgd29uJ3QgY2hhbmdlLCBoZW5jZSBjYW4ndAo+Pj4gICBs ZWFrLgo+Pj4gLSBEcml2ZXJzIHVzaW5nIGRybV9hdG9taWNfaGVscGVyX3NodXRkb3duIGNhbGwg dGhlIGZiZGV2IGNsZWFudXAKPj4+ICAgZmlyc3QsIGFuZCB0aGF0IHVzdWFsbHkgY2xlYW5zIHVw IHRoZSBmYiB0aHJvdWdoCj4+PiAgIGRybV9yZW1vdmVfZnJhbWVidWZmZXIsIHdoaWNoIGRvZXMg dGhpcyBjb3JyZWN0bHkuCj4+PiAtIFdpdGhvdXQgZmJkZXYgdGhlIG9ubHkgZnJhbWVidWZmZXJz IGFyZSBmcm9tIHVzZXJzcGFjZSwgYW5kIHRob3NlCj4+PiAgIGdldCBjbGVhbmVkIHVwIChhZ2Fp biB1c2luZyBkcm1fcmVtb3ZlX2ZyYW1lYnVmZmVyKSBiZWZvciB0aGUgZHJpdmVyCj4+PiAgIGNh biBldmVuIGJlIHVubG9hZGVkLgo+Pj4KPj4+IEJ1dCBpbiBpOTE1IEkndmUgc3dpdGNoZWQgdGhl IGNsZWFudXAgc2VxdWVuY2UgYXJvdW5kIHNvIHRoYXQgdGhlCj4+PiBfc2h1dGRvd24oKSBjYWxs cyBoYXBwZW5zIGFmdGVyIHRoZSBkcm1fcmVtb3ZlX2ZyYW1lYnVmZmVyKCksIHdoaWNoIGlzCj4+ PiBob3cgSSBkaXNjb3ZlcmVkIHRoaXMgaXNzdWUuCj4+Pgo+Pj4gdjI6IE15IGFuYWx5c2lzIHdo eSB0aGUgY3VycmVudCBjb2RlIHdhcyBvayBmb3IgZ3B1IHJlc2V0IGFuZAo+Pj4gc3VzcGVuZC9y ZXN1bWUgd2FzIGNvcnJlY3QsIGJ1dCB0aGVuIEkgdG90YWxseSBmYWlsZWQgdG8gcmVhbGl6ZSB0 aGF0Cj4+PiB3ZSBiZXR0ZXIga2VlcCB0aGlzIHN5bW1ldHJpYy4gVGhhbmtzZnVsbHkgQ0kgbm90 aWNlZCB0aGF0IGZvcgo+Pj4gYmFsYW5jZSwgYSByZWZjb3VudGluZyBidWcgbXVzdCBleGlzdCBh dCAyIHBsYWNlcyBpZiBwcmV2aW91c2x5IHRoZXJlCj4+PiB3YXMgbm8gaXNzdWUgLi4uCj4+Pgo+ Pj4gdjM6IERvbid0IGJlIGxhenkgYW5kIGNvbXB1dGUgdGhlIHBsYW5lX21hc2sgaW4KPj4+IGNv bW1pdF9kdXBsaWNhdGVkX3N0YXRlIHByb3Blcmx5IHRvbywgaW5zdGVhZCBvZiBqdXN0IHVzaW5n IH4wVS4KPj4+Cj4+PiBDYzogbWFydGluLnBlcmVzQGZyZWUuZnIKPj4+IENjOiBjaHJpc0BjaHJp cy13aWxzb24uY28udWsKPj4+IEFja2VkLWJ5OiBEYXZlIEFpcmxpZSA8YWlybGllZEBnbWFpbC5j b20+ICh2MSkKPj4+IFNpZ25lZC1vZmYtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJA aW50ZWwuY29tPgo+Pj4gLS0tCj4+PiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVy LmMgfCAxOCArKysrKysrKysrKysrKysrLS0KPj4+ICAxIGZpbGUgY2hhbmdlZCwgMTYgaW5zZXJ0 aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2RybV9hdG9taWNfaGVscGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxw ZXIuYwo+Pj4gaW5kZXggYjA3ZmMzMDM3MmQzLi41NDUzMjhhOWE3NjkgMTAwNjQ0Cj4+PiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+Pj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPj4+IEBAIC0yNzI2LDYgKzI3MjYsNyBAQCBpbnQg ZHJtX2F0b21pY19oZWxwZXJfZGlzYWJsZV9hbGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPj4+ ICAJc3RydWN0IGRybV9wbGFuZSAqcGxhbmU7Cj4+PiAgCXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAq Y3J0Y19zdGF0ZTsKPj4+ICAJc3RydWN0IGRybV9jcnRjICpjcnRjOwo+Pj4gKwl1bnNpZ25lZCBw bGFuZV9tYXNrID0gMDsKPj4+ICAJaW50IHJldCwgaTsKPj4+ICAKPj4+ICAJc3RhdGUgPSBkcm1f YXRvbWljX3N0YXRlX2FsbG9jKGRldik7Cj4+PiBAQCAtMjc2OCwxMCArMjc2OSwxNCBAQCBpbnQg ZHJtX2F0b21pY19oZWxwZXJfZGlzYWJsZV9hbGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPj4+ ICAJCQlnb3RvIGZyZWU7Cj4+PiAgCj4+PiAgCQlkcm1fYXRvbWljX3NldF9mYl9mb3JfcGxhbmUo cGxhbmVfc3RhdGUsIE5VTEwpOwo+Pj4gKwkJcGxhbmVfbWFzayB8PSBCSVQoZHJtX3BsYW5lX2lu ZGV4KHBsYW5lKSk7Cj4+PiArCQlwbGFuZS0+b2xkX2ZiID0gcGxhbmUtPmZiOwo+Pj4gIAl9Cj4+ PiAgCj4+PiAgCXJldCA9IGRybV9hdG9taWNfY29tbWl0KHN0YXRlKTsKPj4+ICBmcmVlOgo+Pj4g KwlpZiAocGxhbmVfbWFzaykKPj4+ICsJCWRybV9hdG9taWNfY2xlYW5fb2xkX2ZiKGRldiwgcGxh bmVfbWFzaywgcmV0KTsKPj4+ICAJZHJtX2F0b21pY19zdGF0ZV9wdXQoc3RhdGUpOwo+Pj4gIAly ZXR1cm4gcmV0Owo+Pj4gIH0KPj4+IEBAIC0yOTAyLDExICsyOTA3LDE2IEBAIGludCBkcm1fYXRv bWljX2hlbHBlcl9jb21taXRfZHVwbGljYXRlZF9zdGF0ZShzdHJ1Y3QgZHJtX2F0b21pY19zdGF0 ZSAqc3RhdGUsCj4+PiAgCXN0cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRlICpuZXdfY29ubl9zdGF0 ZTsKPj4+ICAJc3RydWN0IGRybV9jcnRjICpjcnRjOwo+Pj4gIAlzdHJ1Y3QgZHJtX2NydGNfc3Rh dGUgKm5ld19jcnRjX3N0YXRlOwo+Pj4gKwl1bnNpZ25lZCBwbGFuZV9tYXNrID0gMDsKPj4+ICsJ c3RydWN0IGRybV9kZXZpY2UgKmRldiA9IHN0YXRlLT5kZXY7Cj4+PiArCWludCByZXQ7Cj4+PiAg Cj4+PiAgCXN0YXRlLT5hY3F1aXJlX2N0eCA9IGN0eDsKPj4+ICAKPj4+IC0JZm9yX2VhY2hfbmV3 X3BsYW5lX2luX3N0YXRlKHN0YXRlLCBwbGFuZSwgbmV3X3BsYW5lX3N0YXRlLCBpKQo+Pj4gKwlm b3JfZWFjaF9uZXdfcGxhbmVfaW5fc3RhdGUoc3RhdGUsIHBsYW5lLCBuZXdfcGxhbmVfc3RhdGUs IGkpIHsKPj4+ICsJCXBsYW5lX21hc2sgfD0gQklUKGRybV9wbGFuZV9pbmRleChwbGFuZSkpOwo+ PiBXZSBzaG91bGQgcmVhbGx5IGFkZCBhIGRybV9wbGFuZV9tYXNrL2RybV9jb25uZWN0b3JfbWFz ayBhdCBzb21lIHBvaW50LCB0byBjb21wbGVtZW50IGRybV9jcnRjX21hc2suCj4+PiAgCQlzdGF0 ZS0+cGxhbmVzW2ldLm9sZF9zdGF0ZSA9IHBsYW5lLT5zdGF0ZTsKPj4+ICsJfQo+Pj4gIAo+Pj4g IAlmb3JfZWFjaF9uZXdfY3J0Y19pbl9zdGF0ZShzdGF0ZSwgY3J0YywgbmV3X2NydGNfc3RhdGUs IGkpCj4+PiAgCQlzdGF0ZS0+Y3J0Y3NbaV0ub2xkX3N0YXRlID0gY3J0Yy0+c3RhdGU7Cj4+PiBA QCAtMjkxNCw3ICsyOTI0LDExIEBAIGludCBkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfZHVwbGlj YXRlZF9zdGF0ZShzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUsCj4+PiAgCWZvcl9lYWNo X25ld19jb25uZWN0b3JfaW5fc3RhdGUoc3RhdGUsIGNvbm5lY3RvciwgbmV3X2Nvbm5fc3RhdGUs IGkpCj4+PiAgCQlzdGF0ZS0+Y29ubmVjdG9yc1tpXS5vbGRfc3RhdGUgPSBjb25uZWN0b3ItPnN0 YXRlOwo+Pj4gIAo+Pj4gLQlyZXR1cm4gZHJtX2F0b21pY19jb21taXQoc3RhdGUpOwo+Pj4gKwly ZXQgPSBkcm1fYXRvbWljX2NvbW1pdChzdGF0ZSk7Cj4+PiArCWlmIChwbGFuZV9tYXNrKQo+Pj4g KwkJZHJtX2F0b21pY19jbGVhbl9vbGRfZmIoZGV2LCBwbGFuZV9tYXNrLCByZXQpOwo+PiBLaWxs IHRoZSBpZiAoKSBwYXJ0LCBhbmQgbWFrZSBpdCB1bmNvbmRpdGlvbmFsPyBPbiBzZWNvbmQgdGhv dWdodCwgSSBzaG91bGQgaGF2ZSBkb25lIHRoZSBzYW1lIGluIGRybV9mcmFtZWJ1ZmZlci5jCj4g SSdkIHByZWZlciB0byBub3QgYmlrZXNoZWQgdGhpcyBzdHVmZiB0b28gbXVjaCBhbmQganVzdCBn byB3aXRoIHdoYXQgd2UgZG8KPiBldmVyeXdoZXJlIGVsc2UgKGkuZS4gcm1mYiBjb2RlIGFuZCBh dG9taWMgY29tbWl0KSBmb3IgY29uc2lzdGVuY3kuCj4gY2xlYW5fb2xkX2ZiIGlzIGRlZmluaXRl bHkgYSBob3JyaWJsZSBmdW5jdGlvbiB3aXRoIG1pc2xlYWRpbmcga2VybmVsZG9jCj4gb24gdG9w LCBhbmQgSSB0aGluayB0aGUgYmVzdCB3YXkgdG8gY2xlYW4gdGhhdCB1cCB3b3VsZCBiZSB0bzoK Pgo+IC0gTW92ZSB0aGUgcGxhbmVfbWFzayBjb21wdXRhdGlvbiBpbiBkcm1fYXRtaWNfY29tbWl0 IGFuZCBhbHNvIHB1dCB0aGUKPiAgIGNsZWFuX29sZF9mYiBjYWxsIGluIHRoZXJlLiBNYXliZSBn aXZlIGl0IGEgbW9yZSBkZXNjcmlwdGl2ZSBuYW1lIGxpa2UKPiAgIHVwZGF0ZV9sZWdhY3lfZmIg b3Igd2hhdGV2ZXIuIFVuZXhwb3J0IHRoZW0uCj4KPiAtIFRoaXMgd291bGQgYnJlYWsgdGhlIGNv bXBhdCBoZWxwZXJzLCB3aGVyZSBkcm1fYXRvbWljX2NvbW1pdCBtdXN0IG5vdAo+ICAgdXBkYXRl IHRoZSBsZWdhY3kgcmVmY291bnRzLCBiZWNhdXNlIGZvciBzZXRfY29uZmlnLCBwYWdlX2ZsaXAg YW5kIHRoZQo+ICAgcGxhbmUgaG9va3MgdGhlIGNvcmUgZG9lcyB0aGF0IGFscmVhZHkuIENyZWF0 ZSBhCj4gICBkcm1fYXRvbWljX2NvbW1pdF9sZWdhY3kgZm9yIHRoZXNlLgo+Cj4gQnV0IHNpbmNl IG9uZSBvZiBteSBwYXRjaGVzIGNhdXNlZCBhbiBleGlzdGluZyBpc3N1ZSB0byBwb3AgdXAgYXMg YQo+IHJlZ3Jlc3Npb24sIGFuZCB0aGlzIHNlcmllcyBmaXhlcyBpdCwgSSdkIGxpa2UgdG8gZmly c3QgZ2V0IHRoZSBtaW5pbWFsCj4gZml4IGluIHRocm91Z2ggZHJtLWludGVsLiBBbmQgdGhlbiBi aWtlc2hlZCBpdCBwcm9wZXJseSBpbiBkcm0tbWlzYy4KPgo+IFR5cGluZyB0aGUgcGF0Y2hlcyBp cyBhbHNvIGEgYml0IGFubm95aW5nIHJpZ2h0IG5vdyBzaW5jZSBJIGhhdmUgYSBmZXcKPiBvdGhl ciBhdG9taWNfY29tbWl0IHBhdGNoZXMgaW4tZmxpZ2h0IC4uLgpJJ2QgcHJlZmVyIGEgYnJpZ2h0 IGdyYXkgYmlrZXNoZWQsCgpidXQgaGV5Li4KClJldmlld2VkLWJ5OiBNYWFydGVuIExhbmtob3Jz dCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==