References: <20200330125719.766763-1-wardragon78@...277...> From: Paolo Message-ID: <44f9ff30-920a-6d0a-6f77-7de6111c04dc@...277...> Date: Tue, 31 Mar 2020 09:34:00 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/alternative; boundary="------------6281EAEA4B905E7090DB6529" Content-Language: it-IT Subject: Re: [Openvpn-devel] [PATCH] [PATCH v5 1/1] Insert client connection data into PAM environment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: openvpn-devel This is a multi-part message in MIME format. --------------6281EAEA4B905E7090DB6529 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 U28sCmFzIHlvdSBhc2tlZCwgbm93IGEgbWFrZSB0aGUgY29tcGxldGUgcGF0Y2ggZnJvbSBkaWZm IGZyb20gbWFzdGVyIGFuZCBteQpicmFuY2gsIG1ha2luZyB0aGUgY2hhbmdlIHRvIHJlbW90ZSBs ZW5naHQuCgotLS0gYS9zcmMvcGx1Z2lucy9hdXRoLXBhbS9hdXRoLXBhbS5jCisrKyBiL3NyYy9w bHVnaW5zL2F1dGgtcGFtL2F1dGgtcGFtLmMKQEAgLTQ4LDcgKzQ4LDcgQEAKwqAjaW5jbHVkZSA8 c2lnbmFsLmg+CsKgI2luY2x1ZGUgPHN5c2xvZy5oPgrCoCNpbmNsdWRlICJ1dGlscy5oIgotCisj aW5jbHVkZSA8YXJwYS9pbmV0Lmg+CsKgI2luY2x1ZGUgPG9wZW52cG4tcGx1Z2luLmg+CsKgCsKg I2RlZmluZSBERUJVRyh2ZXJiKSAoKHZlcmIpID49IDQpCkBAIC0xMTUsNiArMTE1LDcgQEAgc3Ry dWN0IHVzZXJfcGFzcyB7CsKgwqDCoMKgIGNoYXIgcGFzc3dvcmRbMTI4XTsKwqDCoMKgwqAgY2hh ciBjb21tb25fbmFtZVsxMjhdOwrCoMKgwqDCoCBjaGFyIHJlc3BvbnNlWzEyOF07CivCoMKgwqAg Y2hhciByZW1vdGVbSU5FVDZfQUREUlNUUkxFTl07CsKgCsKgwqDCoMKgIGNvbnN0IHN0cnVjdCBu YW1lX3ZhbHVlX2xpc3QgKm5hbWVfdmFsdWVfbGlzdDsKwqB9OwpAQCAtNTE3LDEzICs1MTgsMTkg QEAgb3BlbnZwbl9wbHVnaW5fZnVuY192MShvcGVudnBuX3BsdWdpbl9oYW5kbGVfdApoYW5kbGUs IGNvbnN0IGludCB0eXBlLCBjb25zdCBjaGEKwqDCoMKgwqDCoMKgwqDCoCBjb25zdCBjaGFyICp1 c2VybmFtZSA9IGdldF9lbnYoInVzZXJuYW1lIiwgZW52cCk7CsKgwqDCoMKgwqDCoMKgwqAgY29u c3QgY2hhciAqcGFzc3dvcmQgPSBnZXRfZW52KCJwYXNzd29yZCIsIGVudnApOwrCoMKgwqDCoMKg wqDCoMKgIGNvbnN0IGNoYXIgKmNvbW1vbl9uYW1lID0gZ2V0X2VudigiY29tbW9uX25hbWUiLCBl bnZwKSA/CmdldF9lbnYoImNvbW1vbl9uYW1lIiwgZW52cCkgOiAiIjsKK8KgwqDCoMKgwqDCoMKg IGNvbnN0IGNoYXIgKnJlbW90ZSA9IGdldF9lbnYoInVudHJ1c3RlZF9pcDYiLCBlbnZwKTsKK8Kg wqDCoMKgwqDCoMKgCivCoMKgwqDCoMKgwqDCoCBpZiAocmVtb3RlID09IE5VTEwpeworwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJlbW90ZSA9IGdldF9lbnYoInVudHJ1c3RlZF9pcCIs IGVudnApOyAvL2lmIE51bGwsIHRyeQp0byB0YWtlIGlwdjQgaWYgbm90IHNldCBpcHY2CivCoMKg wqDCoMKgwqDCoCB9CsKgCsKgwqDCoMKgwqDCoMKgwqAgaWYgKHVzZXJuYW1lICYmIHN0cmxlbih1 c2VybmFtZSkgPiAwICYmIHBhc3N3b3JkKQrCoMKgwqDCoMKgwqDCoMKgIHsKwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIGlmIChzZW5kX2NvbnRyb2woY29udGV4dC0+Zm9yZWdyb3VuZF9mZCwgQ09N TUFORF9WRVJJRlkpID09IC0xCsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHx8IHNl bmRfc3RyaW5nKGNvbnRleHQtPmZvcmVncm91bmRfZmQsIHVzZXJuYW1lKSA9PSAtMQrCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8fCBzZW5kX3N0cmluZyhjb250ZXh0LT5mb3JlZ3Jv dW5kX2ZkLCBwYXNzd29yZCkgPT0gLTEKLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8 fCBzZW5kX3N0cmluZyhjb250ZXh0LT5mb3JlZ3JvdW5kX2ZkLCBjb21tb25fbmFtZSkgPT0gLTEp CivCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfHwgc2VuZF9zdHJpbmcoY29udGV4dC0+ Zm9yZWdyb3VuZF9mZCwgY29tbW9uX25hbWUpID09IC0xCivCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAgfHwgc2VuZF9zdHJpbmcoY29udGV4dC0+Zm9yZWdyb3VuZF9mZCwgcmVtb3RlKSA9 PSAtMSkKwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHsKwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAgZnByaW50ZihzdGRlcnIsICJBVVRILVBBTTogRXJyb3Igc2VuZGluZyBhdXRoIGlu Zm8gdG8KYmFja2dyb3VuZCBwcm9jZXNzXG4iKTsKwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIH0K QEAgLTc1MCw4ICs3NTcsMTYgQEAgcGFtX2F1dGgoY29uc3QgY2hhciAqc2VydmljZSwgY29uc3Qg c3RydWN0CnVzZXJfcGFzcyAqdXApCsKgwqDCoMKgIHN0YXR1cyA9IHBhbV9zdGFydChzZXJ2aWNl LCBuYW1lX3ZhbHVlX2xpc3RfcHJvdmlkZWQgPyBOVUxMIDoKdXAtPnVzZXJuYW1lLCAmY29udiwg JnBhbWgpOwrCoMKgwqDCoCBpZiAoc3RhdHVzID09IFBBTV9TVUNDRVNTKQrCoMKgwqDCoCB7CivC oMKgwqDCoMKgwqDCoCAvKiBTZXQgUEFNX1JIT1NUIGVudmlyb25tZW50IHZhcmlhYmxlICovCivC oMKgwqDCoMKgwqDCoCBpZiAoKih1cC0+cmVtb3RlKSkKK8KgwqDCoMKgwqDCoMKgIHsKK8KgwqDC oMKgwqDCoMKgwqDCoMKgwqAgc3RhdHVzID0gcGFtX3NldF9pdGVtKHBhbWgsIFBBTV9SSE9TVCwg dXAtPnJlbW90ZSk7CivCoMKgwqDCoMKgwqDCoCB9CsKgwqDCoMKgwqDCoMKgwqAgLyogQ2FsbCBQ QU0gdG8gdmVyaWZ5IHVzZXJuYW1lL3Bhc3N3b3JkICovCi3CoMKgwqDCoMKgwqDCoCBzdGF0dXMg PSBwYW1fYXV0aGVudGljYXRlKHBhbWgsIDApOworwqDCoMKgwqDCoMKgwqAgaWYgKHN0YXR1cyA9 PSBQQU1fU1VDQ0VTUykKK8KgwqDCoMKgwqDCoMKgIHsKK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAg c3RhdHVzID0gcGFtX2F1dGhlbnRpY2F0ZShwYW1oLCAwKTsKK8KgwqDCoMKgwqDCoMKgIH0KwqDC oMKgwqDCoMKgwqDCoCBpZiAoc3RhdHVzID09IFBBTV9TVUNDRVNTKQrCoMKgwqDCoMKgwqDCoMKg IHsKwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHN0YXR1cyA9IHBhbV9hY2N0X21nbXQocGFtaCwg MCk7CkBAIC04MzksNyArODU0LDggQEAgcGFtX3NlcnZlcihpbnQgZmQsIGNvbnN0IGNoYXIgKnNl cnZpY2UsIGludCB2ZXJiLApjb25zdCBzdHJ1Y3QgbmFtZV92YWx1ZV9saXN0ICoKwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIGNhc2UgQ09NTUFORF9WRVJJRlk6CsKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIGlmIChyZWN2X3N0cmluZyhmZCwgdXAudXNlcm5hbWUsIHNpemVvZih1cC51 c2VybmFtZSkpID09IC0xCsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg fHwgcmVjdl9zdHJpbmcoZmQsIHVwLnBhc3N3b3JkLApzaXplb2YodXAucGFzc3dvcmQpKSA9PSAt MQotwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfHwgcmVjdl9zdHJpbmco ZmQsIHVwLmNvbW1vbl9uYW1lLApzaXplb2YodXAuY29tbW9uX25hbWUpKSA9PSAtMSkKK8KgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHx8IHJlY3Zfc3RyaW5nKGZkLCB1cC5j b21tb25fbmFtZSwKc2l6ZW9mKHVwLmNvbW1vbl9uYW1lKSkgPT0gLTEKK8KgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHx8IHJlY3Zfc3RyaW5nKGZkLCB1cC5yZW1vdGUsIHNp emVvZih1cC5yZW1vdGUpKSA9PSAtMSkKwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg ewrCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGZwcmludGYoc3RkZXJy LCAiQVVUSC1QQU06IEJBQ0tHUk9VTkQ6IHJlYWQgZXJyb3IKb24gY29tbWFuZCBjaGFubmVsOiBj b2RlPSVkLCBleGl0aW5nXG4iLArCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCBjb21tYW5kKTsKQEAgLTg1Myw2ICs4NjksNyBAQCBwYW1fc2Vy dmVyKGludCBmZCwgY29uc3QgY2hhciAqc2VydmljZSwgaW50IHZlcmIsCmNvbnN0IHN0cnVjdCBu YW1lX3ZhbHVlX2xpc3QgKgrCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCB1cC51c2VybmFtZSwgdXAucGFzc3dvcmQpOwrCoCNlbHNlCsKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZnByaW50ZihzdGRlcnIsICJBVVRI LVBBTTogQkFDS0dST1VORDogVVNFUjogJXNcbiIsCnVwLnVzZXJuYW1lKTsKK8KgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGZwcmludGYoc3RkZXJyLCAiQVVUSC1QQU06IEJB Q0tHUk9VTkQ6IFJFTU9URToKJXNcbiIsIHVwLnJlbW90ZSk7CsKgI2VuZGlmCsKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIH0KCgpJbCAzMC8wMy8yMCAyMjo1OCwgU2VsdmEgTmFpciBo YSBzY3JpdHRvOgo+IEhpLAo+Cj4gT24gTW9uLCBNYXIgMzAsIDIwMjAgYXQgODo1OSBBTSBQYW9s byBDZXJyaXRvIDx3YXJkcmFnb243OEAuLi4yNzcuLi4KPiA8bWFpbHRvOndhcmRyYWdvbjc4QC4u LjI3Ny4uLj4+IHdyb3RlOgo+Cj4gICAgIDEpIHNvIHJlbW90ZSB3YXMgc2V0IHRvIHRoZSBtYXhs ZW5naHQgb2YgaXB2NiBhZGRyZXNzIGRlZmluZWQgaW50bwo+ICAgICBhcnBhL2luZXQuaMKgICsg MSBmb3Igc3RyaW5nIHRlcm1pbmF0b3IKPgo+ICAgICAyKSBJIHJlZmFjdG9yZWQgdGhlIGNhbGwg dG8gZ2V0X2VudiB0byB0YWtlIGZpcnN0IGlwdjYgYWRkcmVzcywgdGhlbgo+ICAgICDCoCDCoG9u bHkgaWYgaXQgaXMgTlVMTCwgaSBtYWtlIGEgY2FsbCBmb3IgaXB2NAo+ICAgICAtLS0KPiAgICAg wqBzcmMvcGx1Z2lucy9hdXRoLXBhbS9hdXRoLXBhbS5jIHwgOCArKysrKy0tLQo+ICAgICDCoDEg ZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4KPiAgICAgZGlm ZiAtLWdpdCBhL3NyYy9wbHVnaW5zL2F1dGgtcGFtL2F1dGgtcGFtLmMKPiAgICAgYi9zcmMvcGx1 Z2lucy9hdXRoLXBhbS9hdXRoLXBhbS5jCj4gICAgIGluZGV4IGFlMGQ0OTVhLi5jZDkxYTMzYyAx MDA2NDQKPiAgICAgLS0tIGEvc3JjL3BsdWdpbnMvYXV0aC1wYW0vYXV0aC1wYW0uYwo+ICAgICAr KysgYi9zcmMvcGx1Z2lucy9hdXRoLXBhbS9hdXRoLXBhbS5jCj4gICAgIEBAIC00OCw3ICs0OCw3 IEBACj4gICAgIMKgI2luY2x1ZGUgPHNpZ25hbC5oPgo+ICAgICDCoCNpbmNsdWRlIDxzeXNsb2cu aD4KPiAgICAgwqAjaW5jbHVkZSAidXRpbHMuaCIKPiAgICAgLQo+ICAgICArI2luY2x1ZGUgPGFy cGEvaW5ldC5oPsKgCj4KPiAgICAgwqAjaW5jbHVkZSA8b3BlbnZwbi1wbHVnaW4uaD4KPgo+ICAg ICDCoCNkZWZpbmUgREVCVUcodmVyYikgKCh2ZXJiKSA+PSA0KQo+ICAgICBAQCAtMTE1LDcgKzEx NSw3IEBAIHN0cnVjdCB1c2VyX3Bhc3Mgewo+ICAgICDCoCDCoCDCoGNoYXIgcGFzc3dvcmRbMTI4 XTsKPiAgICAgwqAgwqAgwqBjaGFyIGNvbW1vbl9uYW1lWzEyOF07Cj4gICAgIMKgIMKgIMKgY2hh ciByZXNwb25zZVsxMjhdOwo+ICAgICAtwqAgwqAgY2hhciByZW1vdGVbNDZdOyAvLzQ2IGFzIGlw djYgZm9ybSBuOm46bjpuOm46bjpkLmQuZC5kIGFuZCArCj4gICAgIHRlcm1pbmF0b3IgXDAKPiAg ICAgK8KgIMKgIGNoYXIgcmVtb3RlW0lORVQ2X0FERFJTVFJMRU4rMV07IC8vSU5FVDZfQUREUlNU UkxFTsKgIGlzIHRoZQo+ICAgICBsZW5naHQgb2YgaXB2NiArIHRlcm1pbmF0b3IgXDAKPgo+Cj4g SU5FVDZfQUREUlNUUkxFTiA9IDQ2IGFscmVhZHkgaW5jbHVkZXMgc3BhY2UgZm9yIG51bCB0ZXJt aW5hdGlvbsKgCj4KPiBNb3JlIGltcG9ydGFudGx5LCB5b3UgaGF2ZSB0byBwcm92aWRlIGEgc2lu Z2xlIHVwZGF0ZWQgcGF0Y2jCoAo+IHByZWZlcmFibHnCoHdpdGggdmVyc2lvbiBpbmRpY2F0ZWQg aW4gdGhlIHN1YmplY3QgYW5kIHNlbnQgb3V0IHdpdGgKPiAtLWluLXJlcGx5LXRvIDxtc2dpZD4g cmVmZXJyaW5nIHRvIHRoZSBwcmV2aW91cyB2ZXJzaW9uLgo+Cj4gU3VibWl0dGluZyBpbmNyZW1l bnRhbCBwaWVjZXMgb2YgZml4dXAgY29tbWl0cyBkb2Vzbid0IGhlbHAuIEFuZCBwbGVhc2UKPiB3 YWl0IGZvciByZXZpZXcgYmVmb3JlIG1ha2luZyBjaGFuZ2VzIHVubGVzcyBjb3JyZWN0aW5nIGEg Y3JpdGljYWwgZXJyb3IuCj4KPiBUaGFua3MsCj4KPiBTZWx2YQoKCi0tIAotLS0tLSoqKioqKioq KioqLS0tLS0KUGFvbG8gQ2Vycml0bwotLS0tLSoqKioqKioqKioqLS0tLS0KCg== --------------6281EAEA4B905E7090DB6529 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
So,
as you asked, now a make the complete patch from diff from master and my branch, making the change to remote lenght.

--- a/src/plugins/auth-pam/auth-pam.c
+++ b/src/plugins/auth-pam/auth-pam.c
@@ -48,7 +48,7 @@
 #include <signal.h>
 #include <syslog.h>
 #include "utils.h"
-
+#include <arpa/inet.h>
 #include <openvpn-plugin.h>
 
 #define DEBUG(verb) ((verb) >= 4)
@@ -115,6 +115,7 @@ struct user_pass {
     char password[128];
     char common_name[128];
     char response[128];
+    char remote[INET6_ADDRSTRLEN];
 
     const struct name_value_list *name_value_list;
 };
@@ -517,13 +518,19 @@ openvpn_plugin_func_v1(openvpn_plugin_handle_t handle, const int type, const cha
         const char *username = get_env("username", envp);
         const char *password = get_env("password", envp);
         const char *common_name = get_env("common_name", envp) ? get_env("common_name", envp) : "";
+        const char *remote = get_env("untrusted_ip6", envp);
+       
+        if (remote == NULL){
+                remote = get_env("untrusted_ip", envp); //if Null, try to take ipv4 if not set ipv6
+        }
 
         if (username && strlen(username) > 0 && password)
         {
             if (send_control(context->foreground_fd, COMMAND_VERIFY) == -1
                 || send_string(context->foreground_fd, username) == -1
                 || send_string(context->foreground_fd, password) == -1
-                || send_string(context->foreground_fd, common_name) == -1)
+                || send_string(context->foreground_fd, common_name) == -1
+                || send_string(context->foreground_fd, remote) == -1)
             {
                 fprintf(stderr, "AUTH-PAM: Error sending auth info to background process\n");
             }
@@ -750,8 +757,16 @@ pam_auth(const char *service, const struct user_pass *up)
     status = pam_start(service, name_value_list_provided ? NULL : up->username, &conv, &pamh);
     if (status == PAM_SUCCESS)
     {
+        /* Set PAM_RHOST environment variable */
+        if (*(up->remote))
+        {
+            status = pam_set_item(pamh, PAM_RHOST, up->remote);
+        }
         /* Call PAM to verify username/password */
-        status = pam_authenticate(pamh, 0);
+        if (status == PAM_SUCCESS)
+        {
+            status = pam_authenticate(pamh, 0);
+        }
         if (status == PAM_SUCCESS)
         {
             status = pam_acct_mgmt(pamh, 0);
@@ -839,7 +854,8 @@ pam_server(int fd, const char *service, int verb, const struct name_value_list *
             case COMMAND_VERIFY:
                 if (recv_string(fd, up.username, sizeof(up.username)) == -1
                     || recv_string(fd, up.password, sizeof(up.password)) == -1
-                    || recv_string(fd, up.common_name, sizeof(up.common_name)) == -1)
+                    || recv_string(fd, up.common_name, sizeof(up.common_name)) == -1
+                    || recv_string(fd, up.remote, sizeof(up.remote)) == -1)
                 {
                     fprintf(stderr, "AUTH-PAM: BACKGROUND: read error on command channel: code=%d, exiting\n",
                             command);
@@ -853,6 +869,7 @@ pam_server(int fd, const char *service, int verb, const struct name_value_list *
                             up.username, up.password);
 #else
                     fprintf(stderr, "AUTH-PAM: BACKGROUND: USER: %s\n", up.username);
+                    fprintf(stderr, "AUTH-PAM: BACKGROUND: REMOTE: %s\n", up.remote);
 #endif
                 }


Il 30/03/20 22:58, Selva Nair ha scritto:
Hi,

On Mon, Mar 30, 2020 at 8:59 AM Paolo Cerrito <wardragon78@...277...> wrote:
1) so remote was set to the maxlenght of ipv6 address defined into
arpa/inet.h  + 1 for string terminator

2) I refactored the call to get_env to take first ipv6 address, then
   only if it is NULL, i make a call for ipv4
---
 src/plugins/auth-pam/auth-pam.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/plugins/auth-pam/auth-pam.c b/src/plugins/auth-pam/auth-pam.c
index ae0d495a..cd91a33c 100644
--- a/src/plugins/auth-pam/auth-pam.c
+++ b/src/plugins/auth-pam/auth-pam.c
@@ -48,7 +48,7 @@
 #include <signal.h>
 #include <syslog.h>
 #include "utils.h"
-
+#include <arpa/inet.h> 
 #include <openvpn-plugin.h>

 #define DEBUG(verb) ((verb) >= 4)
@@ -115,7 +115,7 @@ struct user_pass {
     char password[128];
     char common_name[128];
     char response[128];
-    char remote[46]; //46 as ipv6 form n:n:n:n:n:n:d.d.d.d and + terminator \0
+    char remote[INET6_ADDRSTRLEN+1]; //INET6_ADDRSTRLEN  is the lenght of ipv6 + terminator \0

INET6_ADDRSTRLEN = 46 already includes space for nul termination 

More importantly, you have to provide a single updated patch 
preferably with version indicated in the subject and sent out with
--in-reply-to <msgid> referring to the previous version.

Submitting incremental pieces of fixup commits doesn't help. And please
wait for review before making changes unless correcting a critical error.

Thanks,

Selva


-- 
-----***********-----
Paolo Cerrito
-----***********-----
--------------6281EAEA4B905E7090DB6529--