From: Jeff Garzik Subject: Re: [PATCH] linux/magic.h for magic numbers Date: Sat, 09 Sep 2006 09:44:15 -0400 Message-ID: <4502C52F.9080900@garzik.org> References: <20060909110245.GA9617@havoc.gtf.org> <4502C086.2080302@garzik.org> <20060909133334.GB17085@uranus.ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Grzegorz Kulewski , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, akpm@osdl.org Return-path: To: Sam Ravnborg In-Reply-To: <20060909133334.GB17085@uranus.ravnborg.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Sam Ravnborg wrote: > But do we want one common set of magic numbers or do we try to divide it > up per subssystem. The lattter approach are used for many other purposes > so why not for magics too? > Or in other word magic.h => fs_magic.h It's a fair question. I would say, let need dictate the rename. linux/poison.h covers many subsystems. And even across the entire kernel, we don't often add magic numbers... Jeff