From: Jeff Garzik Subject: Re: [PATCH] linux/magic.h for magic numbers Date: Tue, 12 Sep 2006 08:30:38 -0400 Message-ID: <4506A86E.7000105@garzik.org> References: <20060909110245.GA9617@havoc.gtf.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:59864 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S965202AbWILMao (ORCPT ); Tue, 12 Sep 2006 08:30:44 -0400 To: Ian Kent , akpm@osdl.org In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Ian Kent wrote: > On Sat, 9 Sep 2006, Jeff Garzik wrote: > >> An IRC discussion sparked a memory: most filesystems really don't >> need to put anything at all in include/linux. Excluding API-ish >> filesystems like procfs, just about the only filesystem symbols that >> get exported outside of __KERNEL__ are the *_SUPER_MAGIC symbols, >> and similar symbols. >> >> After seeing the useful attributes of linux/poison.h, I propose a >> similar linux/magic.h. >> >> We can see from the patch below that this permitted the deletion of a >> couple headers, where the *_SUPER_MAGIC symbol was the only thing in the >> entire header. >> >> Other non-filesystem-related magic numbers could get moved here >> eventually, if maintainers so desire, but I wanted to start off with the >> obvious low-hanging fruit. >> > > Would be good to include autofs in this lot. > > Defined in linux/autofs/autofs_i.h > Defined in linux/autofs4/autofs_i.h > > as > > #define AUTOFS_SUPER_MAGIC 0x0187 Updated. Andrew, please add the "magic" branch of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git to the list of trees you pull. Thanks, Jeff