From: "Jan Beulich" Subject: Re: [PATCH] x86-64: suppress some unneeded side effects of -fPIC Date: Wed, 13 Sep 2006 15:07:14 +0100 Message-ID: <45082CB2.76E4.0078.0@novell.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org >>> Keir Fraser 13.09.06 15:15 >>> >On 13/9/06 14:12, "Keir Fraser" wrote: >>> Hmm, bad luck, this time I had hoped it'll take you a little longer to commit >>> it, as we've found a better solution: Using #pragma GCC visibility, *all* >>> data references benefit, not just the ones to objects defined in the same >>> translation unit. However, as this now is a header file change, detection >>> logic cannot be used as nicely, so I guess we want to keep the previous >>> change and add this one on top. >>> >>> Signed-off-by: Jan Beulich >> >> It does stack okay on top of command-line option? I'm assuming so, and I'll >> check in this new patch in addition to the one I already committed. Yes, it should. >Actually, another question first: if gcc does not understand the pragma will >it silently ignore it? Then we could get rid of check for GNUC>3, and we >could get rid of -fvisibility=hidden too. You'd get a warning, which is being turned into an error by the build scripts. Jan